-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource usage at sdep level #2484
resource usage at sdep level #2484
Conversation
Thu Sep 24 15:41:33 UTC 2020 impatient try |
Thu Sep 24 15:41:37 UTC 2020 impatient try |
Fri Sep 25 16:02:22 UTC 2020 impatient try |
Fri Sep 25 16:02:25 UTC 2020 impatient try |
Mon Sep 28 14:40:40 UTC 2020 impatient try |
Mon Sep 28 14:41:02 UTC 2020 impatient try |
/lgtm |
@ryandawsonuk: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ryandawsonuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Wed Sep 30 16:28:56 UTC 2020 impatient try |
Wed Sep 30 16:29:06 UTC 2020 impatient try |
fixes #2483
Allows us to apply recording rules based loosely on https://deploy.live/blog/today-i-learned-prometheus-recording-rules/
Not including the recording rules in this PR as can be loaded into configmap and referenced in extraConfigmapMounts. But they're also in the PR's commit history.