Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update seldon-single-model #2435

Merged
merged 3 commits into from
Sep 17, 2020
Merged

Update seldon-single-model #2435

merged 3 commits into from
Sep 17, 2020

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

  • Add further features for deploying prepacked servers from a helm chart
  • Allows MLFlow customizations

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Mon Sep 14 16:04:11 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2435/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2435 --build=1

@seldondev
Copy link
Collaborator

Mon Sep 14 16:04:12 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2435/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2435 --build=2

@axsaucedo
Copy link
Contributor

Interesting, maybe for the parameters we could pass a list of params, so it can provide more flexibility on the parameters that are provided

@ukclivecox ukclivecox merged commit 9806b5d into SeldonIO:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants