Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tf binary from args when creating image for tfserving #2343

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Remove tf binary from args when creating image for tfserving #2343

merged 1 commit into from
Sep 18, 2020

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:
Fixes suprious tf serving binary in args for tfserving image. Not needed as it has binary as default entrypoint.

Which issue(s) this PR fixes:

Fixes #2133

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@ukclivecox ukclivecox requested a review from adriangonz August 28, 2020 15:07
@seldondev
Copy link
Collaborator

Fri Aug 28 15:08:54 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2343/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2343 --build=1

@seldondev
Copy link
Collaborator

Fri Aug 28 15:08:59 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2343/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2343 --build=2

@axsaucedo
Copy link
Contributor

Nice! This will get rid of the annoying error message on startup
/test integration
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue Sep 1 07:21:38 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2343/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2343 --build=3

@axsaucedo
Copy link
Contributor

Seems the CI may be having problems, 30 tests failed but doesn't seem it could be from currnet PR - re-triggering tests to re-test before diving into it further
/test integration
/hold

@seldondev
Copy link
Collaborator

Tue Sep 1 12:22:10 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2343/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2343 --build=4

@adriangonz
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Wed Sep 2 07:25:42 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2343/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2343 --build=5

@adriangonz
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Wed Sep 2 13:30:18 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2343/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2343 --build=6

@adriangonz
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Thu Sep 3 07:30:08 UTC 2020
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2343/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2343 --build=7

@axsaucedo
Copy link
Contributor

Seems like there is quite a lot of failures in integration test (errors look consistent), may require rebase if it passed locally

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Wed Sep 16 18:06:37 UTC 2020
The logs for [integration] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2343/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2343 --build=8

@axsaucedo
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Thu Sep 17 18:22:52 UTC 2020
The logs for [integration] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2343/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2343 --build=9

@axsaucedo
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Thu Sep 17 19:32:27 UTC 2020
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2343/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2343 --build=10

@ukclivecox ukclivecox merged commit 8a4e5b8 into SeldonIO:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicate tensorflow_model_server command between entrypoint and args using prepackaged inference server
4 participants