-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tf binary from args when creating image for tfserving #2343
Conversation
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
Fri Aug 28 15:08:54 UTC 2020 impatient try |
Fri Aug 28 15:08:59 UTC 2020 impatient try |
Nice! This will get rid of the annoying error message on startup |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tue Sep 1 07:21:38 UTC 2020 impatient try |
Seems the CI may be having problems, 30 tests failed but doesn't seem it could be from currnet PR - re-triggering tests to re-test before diving into it further |
Tue Sep 1 12:22:10 UTC 2020 impatient try |
/test integration |
Wed Sep 2 07:25:42 UTC 2020 impatient try |
/test integration |
Wed Sep 2 13:30:18 UTC 2020 impatient try |
/test integration |
Thu Sep 3 07:30:08 UTC 2020 impatient try |
Seems like there is quite a lot of failures in integration test (errors look consistent), may require rebase if it passed locally |
/test integration |
Wed Sep 16 18:06:37 UTC 2020 impatient try |
/test integration |
Thu Sep 17 18:22:52 UTC 2020 impatient try |
/test integration |
Thu Sep 17 19:32:27 UTC 2020 impatient try |
What this PR does / why we need it:
Fixes suprious tf serving binary in args for tfserving image. Not needed as it has binary as default entrypoint.
Which issue(s) this PR fixes:
Fixes #2133
Special notes for your reviewer:
Does this PR introduce a user-facing change?: