Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s 1.18 fix #2339

Merged
merged 2 commits into from
Aug 30, 2020
Merged

k8s 1.18 fix #2339

merged 2 commits into from
Aug 30, 2020

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:
Allows Seldon Core to be deployed on k8s >=1.18

  • Adds a v1 CRD to kustomize.
  • Updates helm to choose between v1beta1 and v1 CRDs based on k8s version.
  • Adds a script to generate graph childen to a greater depth. Unfortunately references are still not allowed in OpenAPISchema and anyway this structure is recursive.

Notes:

  • v1 CRD is structural.
  • v1 CRD does not need volumes hack due to k8s fixes in k8s 1.18

Which issue(s) this PR fixes:

Fixes #1675
Fixes #926
Fixes #1864
Fixes #641

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

k8s 1.18 compatability

@seldondev
Copy link
Collaborator

Fri Aug 28 10:36:01 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2339/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2339 --build=1

@seldondev
Copy link
Collaborator

Fri Aug 28 10:36:48 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2339/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2339 --build=2

@ukclivecox ukclivecox changed the title WIP: k8s 1.18 fix k8s 1.18 fix Aug 28, 2020
@ukclivecox ukclivecox requested a review from axsaucedo August 28, 2020 10:39
@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Fri Aug 28 10:41:27 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2339/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2339 --build=3

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Fri Aug 28 15:19:25 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2339/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2339 --build=4

@seldondev
Copy link
Collaborator

Fri Aug 28 16:48:28 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2339/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2339 --build=6

@seldondev
Copy link
Collaborator

Fri Aug 28 16:48:32 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2339/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2339 --build=5

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Fri Aug 28 17:39:06 UTC 2020
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2339/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2339 --build=7

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Sat Aug 29 07:52:25 UTC 2020
The logs for [integration] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2339/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2339 --build=8

@axsaucedo
Copy link
Contributor

/test lint
/test this

@seldondev
Copy link
Collaborator

Sat Aug 29 10:15:19 UTC 2020
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2339/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2339 --build=10

@seldondev
Copy link
Collaborator

Sat Aug 29 10:15:37 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2339/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2339 --build=9

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Sat Aug 29 11:21:05 UTC 2020
The logs for [integration] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2339/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2339 --build=11

@seldondev
Copy link
Collaborator

@cliveseldon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration af843c0 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor

Nice one! I've tested in kubernetes 1.18 and Kubernetes 1.12 and can confirms it works as expected.

Two things that would be good to add issues for to follow up:

  • Pinning the version of the integration tests to k8s 1.18 (or a specific version
  • Updating the operator and executor golang dependencies to 1.18 (from 1.17)

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit 0ff3a36 into SeldonIO:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants