-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k8s 1.18 fix #2339
k8s 1.18 fix #2339
Conversation
Fri Aug 28 10:36:01 UTC 2020 impatient try |
Fri Aug 28 10:36:48 UTC 2020 impatient try |
/test integration |
Fri Aug 28 10:41:27 UTC 2020 impatient try |
/test integration |
Fri Aug 28 15:19:25 UTC 2020 impatient try |
Fri Aug 28 16:48:28 UTC 2020 impatient try |
Fri Aug 28 16:48:32 UTC 2020 impatient try |
/test integration |
Fri Aug 28 17:39:06 UTC 2020 impatient try |
/test integration |
Sat Aug 29 07:52:25 UTC 2020 impatient try |
/test lint |
Sat Aug 29 10:15:19 UTC 2020 impatient try |
Sat Aug 29 10:15:37 UTC 2020 impatient try |
/test integration |
Sat Aug 29 11:21:05 UTC 2020 impatient try |
@cliveseldon: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
Nice one! I've tested in kubernetes 1.18 and Kubernetes 1.12 and can confirms it works as expected. Two things that would be good to add issues for to follow up:
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Allows Seldon Core to be deployed on k8s >=1.18
Notes:
Which issue(s) this PR fixes:
Fixes #1675
Fixes #926
Fixes #1864
Fixes #641
Special notes for your reviewer:
Does this PR introduce a user-facing change?: