Add SELDON_ENVIRONMENT to Index Name

[sercostr]

What this PR does / why we need it:

SELDON_ENVIRONMENT variable added to the logging "inference-log"

Which issue(s) this PR fixes:

Fixes #2328

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[seldondev]

Hi @sercostr. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[seldondev]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rafalskolasinski
You can assign the PR to them by writing /assign @rafalskolasinski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ryandawsonuk]

/ok-to-test

[ryandawsonuk]

Would be good to also add field to the body of the logged request but that could be handled as a separate issue/follow-up
/lgtm
/approve

[seldondev]

Wed Aug 26 12:14:33 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2329/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2329 --build=2

[seldondev]

Wed Aug 26 12:14:38 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2329/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2329 --build=1

[ryandawsonuk]

/test this

[seldondev]

Wed Aug 26 15:58:11 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2329/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2329 --build=3

[axsaucedo]

@omerfsen thank you very much! One small request, could we rename the env var to something more descriptive? "SELDON_ENVIRONMENT" is a bit too generic, and could be confusing. Maybe somethin that mentions elastic / request logger (cc @ryandawsonuk )
/hold

[axsaucedo]

Sorry for not mentioning this earlier, completely slipped - @ryandawsonuk if we're happy to do it in a separate pr happy to move forward as I don't want to hold it back if it will take too long (and it is quite a fast change)

[axsaucedo]

Actually I think this is definitely good for now in general tbh, and we can make it clear in the documentation. Thanks again for the contribution @omerfsen !
/hold cancel

[seldondev]

@sercostr: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pr-build	7395c53	link	/test this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

[axsaucedo]

Looking at the failed tests, we're currnetly aware they are flaky, and they are passing in two of the three TOX runs, so we can go ahead