Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fluentd-values.yaml #2306

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Update fluentd-values.yaml #2306

merged 1 commit into from
Aug 21, 2020

Conversation

omerfsen
Copy link
Contributor

with current line ( logstash_prefix: 'kubernetes_cluster') it does not work and logs to default index called logstash so this fixes it.

What this PR does / why we need it:

There is nothing like logstash_prefix: 'kubernetes_cluster' (maybe old syntax) new one is like I have added.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

with current line ( logstash_prefix: 'kubernetes_cluster') it does not work and logs to default index called logstash so this fixes it.
@seldondev
Copy link
Collaborator

Hi @omerfsen. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@ryandawsonuk ryandawsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ryandawsonuk
Copy link
Contributor

/ok-to-test

@seldondev
Copy link
Collaborator

Fri Aug 21 08:26:57 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2306/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2306 --build=1

@seldondev
Copy link
Collaborator

Fri Aug 21 08:27:05 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2306/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2306 --build=2

@seldondev
Copy link
Collaborator

@omerfsen: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
lint abfba9b link /test lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ryandawsonuk
Copy link
Contributor

ryandawsonuk commented Aug 21, 2020

Failure looks like an unrelated problem. Seems the executor's go code is failing linting in master.

@ryandawsonuk
Copy link
Contributor

Merging this as will look at linting under #2309

@ryandawsonuk ryandawsonuk merged commit 103802c into SeldonIO:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants