-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fluentd-values.yaml #2306
Conversation
with current line ( logstash_prefix: 'kubernetes_cluster') it does not work and logs to default index called logstash so this fixes it.
Hi @omerfsen. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/ok-to-test |
Fri Aug 21 08:26:57 UTC 2020 impatient try |
Fri Aug 21 08:27:05 UTC 2020 impatient try |
@omerfsen: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
Failure looks like an unrelated problem. Seems the executor's go code is failing linting in master. |
Merging this as will look at linting under #2309 |
with current line ( logstash_prefix: 'kubernetes_cluster') it does not work and logs to default index called logstash so this fixes it.
What this PR does / why we need it:
There is nothing like logstash_prefix: 'kubernetes_cluster' (maybe old syntax) new one is like I have added.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: