Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.md #2304

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Update install.md #2304

merged 1 commit into from
Aug 27, 2020

Conversation

omerfsen
Copy link
Contributor

What this PR does / why we need it:
To state Isito or Ambassador is required for a normal setup

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@seldondev
Copy link
Collaborator

Hi @omerfsen. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor

Thank you for the contribution Omer - in this case you are linking specifically the auth page (as opposed to the generic istio / ambassador page). The ingress is not necessary to set up seldon core (we do have a smaller number of users running seldon core in closed environments where non-supported ingress are configured), so probably we can leave it out. I do believe ingress is mentioned in the documentation lower down the page. Are there any reasons why the installation below that outlines istio/ambassador with detailed pages are not enough?

@ryandawsonuk
Copy link
Contributor

Would do you reckon to moving the 'Ingress Support' section from https://github.com/SeldonIO/seldon-core/blob/master/doc/source/workflow/install.md further up the page so that it comes before 'Install a specific version'? Currently we've got a paragraph that ends with 'install it with the relevant ingress (ambassador.enabled or istio.enabled) so you are able to send requests (instructions below).' and then 'instructions below' are quite a long way down.

@ukclivecox ukclivecox merged commit 5d1687d into SeldonIO:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants