Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 1.2.3 dev tag to prepare for release #2274

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

axsaucedo
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

Thu Aug 13 14:37:46 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2274/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2274 --build=1

@seldondev
Copy link
Collaborator

Thu Aug 13 14:38:47 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2274/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2274 --build=2

@ukclivecox
Copy link
Contributor

/approve

@ukclivecox ukclivecox merged commit 3cefc46 into SeldonIO:master Aug 13, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

@axsaucedo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pr-build 7a83a0b link /test this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants