Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes template #2190

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Conversation

adriangonz
Copy link
Contributor

What this PR does / why we need it:
Fetch the release-notes block of every PR merged between 2 particular tags to generate easy-to-follow release notes.

Which issue(s) this PR fixes:

Fixes #1471

Special notes for your reviewer:
This is mostly a draft PR showing an example format which we could use to generate our release notes. The main goal is to discuss and get people's opinions on the template and how we could integrate them further with our release process.

Does this PR introduce a user-facing change?:

NONE

@seldondev
Copy link
Collaborator

Fri Jul 24 13:15:30 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2190/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2190 --build=1

@seldondev
Copy link
Collaborator

Fri Jul 24 13:16:09 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2190/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2190 --build=2

@adriangonz adriangonz changed the title WIP : Add release notes template Add release notes template Sep 9, 2020
@adriangonz
Copy link
Contributor Author

/cc @gsunner @axsaucedo @cliveseldon

@adriangonz
Copy link
Contributor Author

If we are happy with the template for release notes, we can merge this PR and then enable the Prow / Lighthouse plugin to make sure all PRs have a release-notes block (or have explicitly disabled).

@ukclivecox
Copy link
Contributor

/approve

@ukclivecox ukclivecox merged commit 7138c89 into SeldonIO:master Sep 17, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve release notes
3 participants