assaf-java-s2i-update

[amoldavsky]

What this PR does / why we need it:
Allows more flexibility around the S2I builds by allowing the
source image to be specified as a Docker build argument.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
You can either build the same way as before, OR you can do custom...

bash bin/build.sh \
	--build-source-image seldonio/core-builder:0.15 \
	--runtime-source-image adoptopenjdk/openjdk13:alpine-slim \
	jw-0.2.0-jre-13

Does this PR introduce a user-facing change?:

[seldondev]

Hi @amoldavsky. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[adriangonz]

Thanks for your contribution @amoldavsky ! I've left a couple comments below regarding the versions of the default Docker images (which are a bit outdated). Besides that, everything else looks good!

[adriangonz]

Could you try bumping the core-builder image to 0.16 (which is the latest)?

[adriangonz]

Similarly as above, could you also bump the runtime base to openjdk:13.0.1-jdk-buster (which is what the latest core-builder uses)?

[adriangonz]

/approve

Nice one @amoldavsky ! Thanks for adding those changes in. I think this is good to go now.

[seldondev]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adriangonz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment