Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include reward in metrics on wrapper #2150

Merged
merged 2 commits into from
Jul 21, 2020
Merged

include reward in metrics on wrapper #2150

merged 2 commits into from
Jul 21, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Jul 16, 2020

What this PR does / why we need it:

It makes sure that reward metrics is recorded when model's send-feedback is hit.

Which issue(s) this PR fixes:

Closes #2115

Special notes for your reviewer:

  • adds SELDON_EXECUTOR_ENABLED environmental variable on the wrapper
  • fixes custom metrics tags (keep wrong ones until 1.3 for compatibility reasons)

Does this PR introduce a user-facing change?:

@seldondev
Copy link
Collaborator

Thu Jul 16 22:09:45 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2150/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2150 --build=2

@seldondev
Copy link
Collaborator

Thu Jul 16 22:09:48 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2150/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2150 --build=1

@RafalSkolasinski RafalSkolasinski marked this pull request as draft July 17, 2020 15:00
@seldondev
Copy link
Collaborator

Fri Jul 17 15:01:36 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2150/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2150 --build=4

@seldondev
Copy link
Collaborator

Fri Jul 17 15:01:39 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2150/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2150 --build=3

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks
/test integration

@seldondev
Copy link
Collaborator

Fri Jul 17 15:27:51 UTC 2020
The logs for [notebooks] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2150/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2150 --build=5

@seldondev
Copy link
Collaborator

Fri Jul 17 15:27:54 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2150/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2150 --build=6

@axsaucedo
Copy link
Contributor

/test integration
/test notebooks

@seldondev
Copy link
Collaborator

Fri Jul 17 18:18:21 UTC 2020
The logs for [notebooks] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2150/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2150 --build=7

@seldondev
Copy link
Collaborator

Fri Jul 17 18:20:16 UTC 2020
The logs for [integration] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2150/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2150 --build=8

@RafalSkolasinski RafalSkolasinski marked this pull request as ready for review July 20, 2020 10:57
@RafalSkolasinski
Copy link
Contributor Author

Rebased onto master. Triggering tests to verify if we have flakiness or not (tests passed before).

/test notebooks
/test integration

@seldondev
Copy link
Collaborator

Tue Jul 21 10:29:09 UTC 2020
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2150/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2150 --build=10

@seldondev
Copy link
Collaborator

Tue Jul 21 10:29:43 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2150/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2150 --build=9

@seldondev
Copy link
Collaborator

Tue Jul 21 10:29:47 UTC 2020
The logs for [integration] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2150/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2150 --build=12

@seldondev
Copy link
Collaborator

Tue Jul 21 10:29:55 UTC 2020
The logs for [notebooks] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2150/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2150 --build=11

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 37809d5 into SeldonIO:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to view feedback reward on Grafana dashboard
3 participants