-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include reward in metrics on wrapper #2150
include reward in metrics on wrapper #2150
Conversation
Thu Jul 16 22:09:45 UTC 2020 impatient try |
Thu Jul 16 22:09:48 UTC 2020 impatient try |
Fri Jul 17 15:01:36 UTC 2020 impatient try |
Fri Jul 17 15:01:39 UTC 2020 impatient try |
/test notebooks |
Fri Jul 17 15:27:51 UTC 2020 impatient try |
Fri Jul 17 15:27:54 UTC 2020 impatient try |
/test integration |
Fri Jul 17 18:18:21 UTC 2020 impatient try |
Fri Jul 17 18:20:16 UTC 2020 impatient try |
Rebased onto master. Triggering tests to verify if we have flakiness or not (tests passed before). /test notebooks |
Tue Jul 21 10:29:09 UTC 2020 impatient try |
Tue Jul 21 10:29:43 UTC 2020 impatient try |
Tue Jul 21 10:29:47 UTC 2020 impatient try |
Tue Jul 21 10:29:55 UTC 2020 impatient try |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
It makes sure that
reward metrics
is recorded when model'ssend-feedback
is hit.Which issue(s) this PR fixes:
Closes #2115
Special notes for your reviewer:
SELDON_EXECUTOR_ENABLED
environmental variable on the wrapperDoes this PR introduce a user-facing change?: