Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template with release notes #2086

Merged
merged 3 commits into from
Jul 9, 2020

Conversation

adriangonz
Copy link
Contributor

@adriangonz adriangonz commented Jul 8, 2020

Fixes #1471

Changelog

  • Add PR template with release-notes block
  • Update docs with guidelines on release notes

@seldondev
Copy link
Collaborator

Wed Jul 8 09:36:57 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2086/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2086 --build=1

@seldondev
Copy link
Collaborator

Wed Jul 8 09:37:09 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2086/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2086 --build=2

@adriangonz
Copy link
Contributor Author

/cc @cliveseldon @gsunner @RafalSkolasinski

@axsaucedo
Copy link
Contributor

Nice one!
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor

/test lint

@seldondev
Copy link
Collaborator

Thu Jul 9 08:34:38 UTC 2020
The logs for [lint] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2086/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2086 --build=3

@seldondev
Copy link
Collaborator

Thu Jul 9 08:52:19 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2086/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2086 --build=4

@seldondev
Copy link
Collaborator

Thu Jul 9 08:53:16 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2086/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2086 --build=5

@axsaucedo axsaucedo merged commit a352b9e into SeldonIO:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve release notes
3 participants