Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow independent installation of grafana and prometheus #2057

Conversation

dewnull
Copy link
Contributor

@dewnull dewnull commented Jul 1, 2020

This PR allows installing Grafana without installing Prometheus.
This is useful if you are already have a Prometheus installation, but you want to use this chart to install Grafana with Seldon dashboards.

To install just Grafana or just Prometheus, you can set .enabled to false.

@seldondev
Copy link
Collaborator

Hi @dewnull. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ukclivecox ukclivecox self-requested a review July 2, 2020 10:24
@axsaucedo
Copy link
Contributor

@dewnull that the chart works is by referencing dependencies, right now you are removing some configuration but prometheus and grafana would still always be installed, you would just not override the components. It would be useful to add this functionality, but it would be good if you can test it locally with flags for grafana, and then prometheus separately to confirm it all works

@axsaucedo
Copy link
Contributor

@dewnull any updates?

@axsaucedo
Copy link
Contributor

Just following up on this one @dewnull any updates?

@ukclivecox
Copy link
Contributor

/test integration

@ukclivecox
Copy link
Contributor

/ok-to-test

@ukclivecox
Copy link
Contributor

/approve

@ukclivecox ukclivecox merged commit 4eb029e into SeldonIO:master Aug 27, 2020
@seldondev
Copy link
Collaborator

Thu Aug 27 10:07:46 UTC 2020
The logs for [integration] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2057/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2057 --build=1

@seldondev
Copy link
Collaborator

Thu Aug 27 10:07:49 UTC 2020
The logs for [pr-build] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2057/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2057 --build=2

@seldondev
Copy link
Collaborator

Thu Aug 27 10:07:53 UTC 2020
The logs for [lint] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2057/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2057 --build=3

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants