-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow independent installation of grafana and prometheus #2057
allow independent installation of grafana and prometheus #2057
Conversation
Hi @dewnull. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dewnull that the chart works is by referencing dependencies, right now you are removing some configuration but prometheus and grafana would still always be installed, you would just not override the components. It would be useful to add this functionality, but it would be good if you can test it locally with flags for grafana, and then prometheus separately to confirm it all works |
@dewnull any updates? |
Just following up on this one @dewnull any updates? |
/test integration |
/ok-to-test |
/approve |
Thu Aug 27 10:07:46 UTC 2020 impatient try |
Thu Aug 27 10:07:49 UTC 2020 impatient try |
Thu Aug 27 10:07:53 UTC 2020 impatient try |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR allows installing Grafana without installing Prometheus.
This is useful if you are already have a Prometheus installation, but you want to use this chart to install Grafana with Seldon dashboards.
To install just Grafana or just Prometheus, you can set
.enabled
tofalse
.