Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ensuring old clusterwide webhook is deleted #2013

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Fix for ensuring old clusterwide webhook is deleted #2013

merged 1 commit into from
Jun 29, 2020

Conversation

ukclivecox
Copy link
Contributor

Fixes #2009

  • Delete the webhook clusterwide configurations if they exist when installing by namespace

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cliveseldon

If they are not already assigned, you can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Jun 26 09:14:53 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2013/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2013 --build=2

@seldondev
Copy link
Collaborator

Fri Jun 26 09:16:11 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2013/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2013 --build=1

@ukclivecox
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Fri Jun 26 09:33:33 UTC 2020
The logs for [notebooks] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2013/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2013 --build=3

@ukclivecox ukclivecox requested a review from ryandawsonuk June 26, 2020 10:50
@seldondev
Copy link
Collaborator

@cliveseldon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
notebooks dbc1767 link /test notebooks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ukclivecox ukclivecox merged commit 04ee26a into SeldonIO:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seldon Operator automatic update from v1.1.0 to v1.2.0 causes seldondeployment failures
2 participants