-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed noEngine #1970
fixed noEngine #1970
Conversation
Hi @chengchengpei. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this is original codes: if This is confusing. we need check the value of there is same concern about Please leave comments, so that I can update the above codes. |
/ok-to-test |
Thu Jun 25 10:01:20 UTC 2020 impatient try |
Thu Jun 25 10:03:01 UTC 2020 impatient try |
/test integration |
Thu Jun 25 11:48:06 UTC 2020 impatient try |
@chengcheng-pei are you planning to add anything more to this PR? |
/retest |
Thu Jun 25 12:26:50 UTC 2020 impatient try |
@RafalSkolasinski I updated my pr. that is all. |
Wed Jul 1 21:59:00 UTC 2020 impatient try |
Wed Jul 1 21:59:01 UTC 2020 impatient try |
Can you add test to operator? |
Fri Jul 3 20:01:31 UTC 2020 impatient try |
Fri Jul 3 20:01:39 UTC 2020 impatient try |
I added tests. @cliveseldon |
/test integration |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thu Jul 9 10:45:29 UTC 2020 impatient try |
/test engine |
Wed Jul 15 13:36:05 UTC 2020 impatient try |
Engine tests and integration test pass |
Fixes #1976