Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed noEngine #1970

Merged
merged 3 commits into from
Jul 15, 2020
Merged

fixed noEngine #1970

merged 3 commits into from
Jul 15, 2020

Conversation

chengchengpei
Copy link
Contributor

@chengchengpei chengchengpei commented Jun 17, 2020

Fixes #1976

Fixed semantics of `seldon.io/no-engine` annotation.

@seldondev
Copy link
Collaborator

Hi @chengchengpei. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chengcheng-pei
Copy link
Contributor

chengcheng-pei commented Jun 18, 2020

this is original codes:
_, noEngine := p.Annotations[machinelearningv1.ANNOTATION_NO_ENGINE]

if machinelearningv1.ANNOTATION_NO_ENGINE in annotations, noEngine is true, otherwise, it is false.

This is confusing. we need check the value of p.Annotations[machinelearningv1.ANNOTATION_NO_ENGINE] instead of whether it exists in the annotations map or not.

there is same concern about _, hasSeparateEnginePod := mlDep.Spec.Annotations[machinelearningv1.ANNOTATION_SEPARATE_ENGINE].

Please leave comments, so that I can update the above codes.

@chengcheng-pei
Copy link
Contributor

#1976

@ukclivecox ukclivecox changed the title fixed noEngine WIP: fixed noEngine Jun 19, 2020
@RafalSkolasinski
Copy link
Contributor

/ok-to-test

@seldondev
Copy link
Collaborator

Thu Jun 25 10:01:20 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1970/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1970 --build=1

@seldondev
Copy link
Collaborator

Thu Jun 25 10:03:01 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1970/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1970 --build=2

@RafalSkolasinski
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Thu Jun 25 11:48:06 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1970/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1970 --build=3

@RafalSkolasinski
Copy link
Contributor

@chengcheng-pei are you planning to add anything more to this PR?

@RafalSkolasinski
Copy link
Contributor

/retest

@seldondev
Copy link
Collaborator

Thu Jun 25 12:26:50 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1970/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1970 --build=4

@chengchengpei
Copy link
Contributor Author

@chengcheng-pei are you planning to add anything more to this PR?

@RafalSkolasinski I updated my pr. that is all.

@seldondev
Copy link
Collaborator

Wed Jul 1 21:59:00 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1970/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1970 --build=6

@seldondev
Copy link
Collaborator

Wed Jul 1 21:59:01 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1970/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1970 --build=5

@chengchengpei chengchengpei changed the title WIP: fixed noEngine fixed noEngine Jul 2, 2020
@ukclivecox
Copy link
Contributor

Can you add test to operator?

@seldondev seldondev added size/L and removed size/XS labels Jul 3, 2020
@seldondev
Copy link
Collaborator

Fri Jul 3 20:01:31 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1970/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1970 --build=8

@seldondev
Copy link
Collaborator

Fri Jul 3 20:01:39 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1970/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1970 --build=7

@chengcheng-pei
Copy link
Contributor

chengcheng-pei commented Jul 3, 2020

Can you add test to operator?

I added tests. @cliveseldon

@ukclivecox
Copy link
Contributor

/test integration

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Thu Jul 9 10:45:29 UTC 2020
The logs for [integration] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1970/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1970 --build=9

@axsaucedo
Copy link
Contributor

/test engine

@seldondev
Copy link
Collaborator

Wed Jul 15 13:36:05 UTC 2020
The logs for [engine] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1970/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1970 --build=10

@axsaucedo
Copy link
Contributor

Engine tests and integration test pass

@axsaucedo axsaucedo merged commit 3730769 into SeldonIO:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

re-define noEngine annotation
6 participants