Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed OpenAPI file permissions within image #1956

Merged

Conversation

axsaucedo
Copy link
Contributor

@axsaucedo axsaucedo commented Jun 15, 2020

Fixes #1955

@axsaucedo
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Mon Jun 15 18:06:15 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1956/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1956 --build=2

@seldondev
Copy link
Collaborator

Mon Jun 15 18:06:16 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1956/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1956 --build=1

@seldondev
Copy link
Collaborator

Mon Jun 15 18:08:17 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1956/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1956 --build=3

@axsaucedo
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Mon Jun 15 19:17:09 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1956/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1956 --build=4

@seldondev
Copy link
Collaborator

Tue Jun 16 05:28:48 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1956/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1956 --build=6

@seldondev
Copy link
Collaborator

Tue Jun 16 05:28:58 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1956/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1956 --build=5

@seldondev
Copy link
Collaborator

Tue Jun 16 05:38:02 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1956/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1956 --build=8

@seldondev
Copy link
Collaborator

Tue Jun 16 05:38:06 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1956/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1956 --build=7

@adriangonz
Copy link
Contributor

/test integration

Interesting! I didn't think this could be a problem but it makes complete sense.

@seldondev
Copy link
Collaborator

Tue Jun 16 08:33:44 UTC 2020
The logs for [integration] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1956/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1956 --build=9

@ukclivecox
Copy link
Contributor

Add for redhat Dockerfile.

@seldondev seldondev added size/S and removed size/XS labels Jun 16, 2020
@seldondev
Copy link
Collaborator

Tue Jun 16 10:25:00 UTC 2020
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1956/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1956 --build=10

@seldondev
Copy link
Collaborator

Tue Jun 16 10:25:03 UTC 2020
The logs for [lint] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1956/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1956 --build=11

@axsaucedo
Copy link
Contributor Author

@cliveseldon @adriangonz I've added the changes for the redhat image to also copy the files with the right permissions

@axsaucedo axsaucedo changed the title Changed owner of openAPI file to 8888 Changed OpenAPI file permissions within image Jun 16, 2020
@adriangonz
Copy link
Contributor

/approve

Looks good to me @axsaucedo!

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue Jun 16 12:52:03 UTC 2020
The logs for [pr-build] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1956/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1956 --build=12

@seldondev
Copy link
Collaborator

Tue Jun 16 12:52:04 UTC 2020
The logs for [lint] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1956/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1956 --build=13

@seldondev
Copy link
Collaborator

seldondev commented Jun 16, 2020

@axsaucedo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 03c4a91 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor Author

/test this

@axsaucedo axsaucedo merged commit 1d96a67 into SeldonIO:master Jun 16, 2020
@seldondev
Copy link
Collaborator

Tue Jun 16 13:42:08 UTC 2020
The logs for [pr-build] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1956/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1956 --build=14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Golang Service Orchestrator (Executor) fails to replace variables since no longer runs root
4 participants