-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added checks to only build components in tests if have been modified #1909
Added checks to only build components in tests if have been modified #1909
Conversation
/test integration |
Tue Jun 2 08:09:02 UTC 2020 impatient try |
Tue Jun 2 08:09:02 UTC 2020 impatient try |
Tue Jun 2 08:10:45 UTC 2020 impatient try |
/test integration |
Tue Jun 2 10:51:43 UTC 2020 impatient try |
/test integration |
Tue Jun 2 12:39:21 UTC 2020 impatient try |
/test lint |
Tue Jun 2 13:39:21 UTC 2020 impatient try |
/test integration |
Tue Jun 2 13:41:35 UTC 2020 impatient try |
/test integration |
Tue Jun 2 14:03:48 UTC 2020 impatient try |
/test lint |
Tue Jun 2 15:10:07 UTC 2020 impatient try |
Thu Jun 4 13:15:43 UTC 2020 impatient try |
Thu Jun 4 13:15:48 UTC 2020 impatient try |
thanks @cliveseldon @adriangonz I've resolved the issue now |
Thu Jun 4 13:20:11 UTC 2020 impatient try |
/approve Looks good @axsaucedo! Although integration tests are failing. Do you know if it's related to the changes? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriangonz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Mon Jun 8 08:10:51 UTC 2020 impatient try |
@axsaucedo: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@adriangonz only test failed was the flaky rolling update one, logs here: https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1909/13.log |
Separated tests component from #1884 to land test optimisation separately