Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checks to only build components in tests if have been modified #1909

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

axsaucedo
Copy link
Contributor

Separated tests component from #1884 to land test optimisation separately

@axsaucedo
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Jun 2 08:09:02 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1909/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1909 --build=1

@seldondev
Copy link
Collaborator

Tue Jun 2 08:09:02 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1909/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1909 --build=2

@seldondev
Copy link
Collaborator

Tue Jun 2 08:10:45 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1909/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1909 --build=3

@axsaucedo
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Jun 2 10:51:43 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1909/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1909 --build=4

@axsaucedo
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Jun 2 12:39:21 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1909/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1909 --build=5

@axsaucedo
Copy link
Contributor Author

/test lint

@seldondev
Copy link
Collaborator

Tue Jun 2 13:39:21 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1909/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1909 --build=6

@axsaucedo
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Jun 2 13:41:35 UTC 2020
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1909/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1909 --build=7

@axsaucedo
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Jun 2 14:03:48 UTC 2020
The logs for [integration] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1909/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1909 --build=8

@axsaucedo
Copy link
Contributor Author

/test lint

@seldondev
Copy link
Collaborator

Tue Jun 2 15:10:07 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1909/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1909 --build=9

@seldondev
Copy link
Collaborator

Thu Jun 4 13:15:43 UTC 2020
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1909/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1909 --build=10

@seldondev
Copy link
Collaborator

Thu Jun 4 13:15:48 UTC 2020
The logs for [lint] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1909/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1909 --build=11

@axsaucedo axsaucedo requested a review from ukclivecox June 4, 2020 13:18
@axsaucedo
Copy link
Contributor Author

thanks @cliveseldon @adriangonz I've resolved the issue now
/test integration

@seldondev
Copy link
Collaborator

Thu Jun 4 13:20:11 UTC 2020
The logs for [integration] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1909/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1909 --build=12

@adriangonz
Copy link
Contributor

/approve
/test integration

Looks good @axsaucedo! Although integration tests are failing. Do you know if it's related to the changes?

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Mon Jun 8 08:10:51 UTC 2020
The logs for [integration] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1909/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1909 --build=13

@seldondev
Copy link
Collaborator

@axsaucedo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 4cfa23b link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor Author

@adriangonz only test failed was the flaky rolling update one, logs here: https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1909/13.log

@adriangonz adriangonz merged commit 5150973 into SeldonIO:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants