-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix content-type behaviour in executor #1900
Conversation
Sat May 30 15:36:23 UTC 2020 impatient try |
Sat May 30 15:37:38 UTC 2020 impatient try |
/test integration |
Sun May 31 07:08:55 UTC 2020 impatient try |
/test notebooks |
Sun May 31 08:55:46 UTC 2020 impatient try |
Sun May 31 15:28:24 UTC 2020 impatient try |
Sun May 31 15:28:23 UTC 2020 impatient try |
Sun May 31 15:29:54 UTC 2020 impatient try |
Sun May 31 15:30:01 UTC 2020 impatient try |
/test integration |
Sun May 31 16:26:20 UTC 2020 impatient try |
/test integration |
Mon Jun 1 07:42:42 UTC 2020 impatient try |
/test integration |
Mon Jun 1 10:25:47 UTC 2020 impatient try |
/test notebooks |
Tue Jun 2 08:13:36 UTC 2020 impatient try |
/test notebooks |
Tue Jun 2 14:13:12 UTC 2020 impatient try |
Tue Jun 16 16:51:42 UTC 2020 impatient try |
Tue Jun 16 16:51:43 UTC 2020 impatient try |
/test integration |
Tue Jun 16 17:10:39 UTC 2020 impatient try |
/test notebooks |
Tue Jun 16 19:44:04 UTC 2020 impatient try |
/test integration |
Tue Jun 16 21:45:13 UTC 2020 impatient try |
Tue Jun 16 21:45:18 UTC 2020 impatient try |
Tue Jun 16 21:46:19 UTC 2020 impatient try |
/test notebooks |
Wed Jun 17 06:32:48 UTC 2020 impatient try |
@cliveseldon: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test integration |
Wed Jun 17 09:55:38 UTC 2020 impatient try |
Wed Jun 17 09:55:49 UTC 2020 impatient try |
Wed Jun 17 09:56:19 UTC 2020 impatient try |
Looks good! |
Looks good from my side @cliveseldon ! Should be good to land once the integration tests pass. 🤞 |
All integration tests pass 🚀 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Wed Jun 17 12:07:30 UTC 2020 impatient try |
Wed Jun 17 12:07:50 UTC 2020 impatient try |
Fixes #1899
Ensure:
Content-Type
passed in initial request is used for initial component REST callContent-Type
from responses in the graph are used for next requestContent-Type