Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content-type behaviour in executor #1900

Merged
merged 6 commits into from
Jun 17, 2020
Merged

Fix content-type behaviour in executor #1900

merged 6 commits into from
Jun 17, 2020

Conversation

ukclivecox
Copy link
Contributor

Fixes #1899

Ensure:

  • Content-Type passed in initial request is used for initial component REST call
  • Content-Type from responses in the graph are used for next request
  • Adding headers to each request from initial headers does not overwrite Content-Type

@seldondev
Copy link
Collaborator

Sat May 30 15:36:23 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=2

@seldondev
Copy link
Collaborator

Sat May 30 15:37:38 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=1

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Sun May 31 07:08:55 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=3

@ukclivecox
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Sun May 31 08:55:46 UTC 2020
The logs for [notebooks] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=4

@seldondev
Copy link
Collaborator

Sun May 31 15:28:24 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=5

@seldondev
Copy link
Collaborator

Sun May 31 15:28:23 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=6

@seldondev
Copy link
Collaborator

Sun May 31 15:29:54 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=8

@seldondev
Copy link
Collaborator

Sun May 31 15:30:01 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=7

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Sun May 31 16:26:20 UTC 2020
The logs for [integration] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=9

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Mon Jun 1 07:42:42 UTC 2020
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=10

@RafalSkolasinski
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Mon Jun 1 10:25:47 UTC 2020
The logs for [integration] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=11

@ukclivecox
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Tue Jun 2 08:13:36 UTC 2020
The logs for [notebooks] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=12

@ukclivecox
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Tue Jun 2 14:13:12 UTC 2020
The logs for [notebooks] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=13

@ukclivecox ukclivecox requested a review from axsaucedo June 4, 2020 09:57
@seldondev
Copy link
Collaborator

Tue Jun 16 16:51:42 UTC 2020
The logs for [lint] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=15

@seldondev
Copy link
Collaborator

Tue Jun 16 16:51:43 UTC 2020
The logs for [pr-build] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=14

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Jun 16 17:10:39 UTC 2020
The logs for [integration] [16] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/16.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=16

@ukclivecox
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Tue Jun 16 19:44:04 UTC 2020
The logs for [notebooks] [17] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/17.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=17

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Jun 16 21:45:13 UTC 2020
The logs for [lint] [19] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/19.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=19

@seldondev
Copy link
Collaborator

Tue Jun 16 21:45:18 UTC 2020
The logs for [pr-build] [18] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/18.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=18

@seldondev
Copy link
Collaborator

Tue Jun 16 21:46:19 UTC 2020
The logs for [integration] [20] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/20.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=20

@ukclivecox
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Wed Jun 17 06:32:48 UTC 2020
The logs for [notebooks] [21] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/21.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=21

@seldondev
Copy link
Collaborator

@cliveseldon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
notebooks 31a5c8e link /test notebooks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

executor/api/rest/client.go Outdated Show resolved Hide resolved
executor/api/rest/client.go Outdated Show resolved Hide resolved
@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Wed Jun 17 09:55:38 UTC 2020
The logs for [lint] [23] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/23.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=23

@seldondev
Copy link
Collaborator

Wed Jun 17 09:55:49 UTC 2020
The logs for [pr-build] [22] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/22.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=22

@seldondev
Copy link
Collaborator

Wed Jun 17 09:56:19 UTC 2020
The logs for [integration] [24] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/24.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=24

@axsaucedo
Copy link
Contributor

Looks good!

@adriangonz
Copy link
Contributor

Looks good from my side @cliveseldon ! Should be good to land once the integration tests pass. 🤞

@axsaucedo
Copy link
Contributor

All integration tests pass 🚀
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Wed Jun 17 12:07:30 UTC 2020
The logs for [lint] [26] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/26.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=26

@seldondev
Copy link
Collaborator

Wed Jun 17 12:07:50 UTC 2020
The logs for [pr-build] [25] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1900/25.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1900 --build=25

@axsaucedo axsaucedo merged commit a810329 into SeldonIO:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multipart form data not passed between chain of seldon components
5 participants