-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally allow manager to create CRD #1848
Conversation
Tue May 19 11:02:40 UTC 2020 impatient try |
Tue May 19 11:02:57 UTC 2020 impatient try |
/test integration |
Tue May 19 13:00:48 UTC 2020 impatient try |
Tue May 19 13:01:05 UTC 2020 impatient try |
Tue May 19 13:01:58 UTC 2020 impatient try |
Thu May 28 07:56:05 UTC 2020 impatient try |
Thu May 28 07:56:21 UTC 2020 impatient try |
All looks good and seems to work! Seems to be some merge conflicts - btw may be worth also adding an entry into the installing.md docs page where we talk about installing seldon with helm namely as we already document some of the options - would also be good to add the descriptions to the helm chart seldon-core-operator |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Sun May 31 07:51:34 UTC 2020 impatient try |
Sun May 31 07:54:50 UTC 2020 impatient try |
/hold cancel |
Fixes #1755
createResources=true
did not created needed RBAC