Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally allow manager to create CRD #1848

Merged
merged 4 commits into from
Jun 1, 2020
Merged

Optionally allow manager to create CRD #1848

merged 4 commits into from
Jun 1, 2020

Conversation

ukclivecox
Copy link
Contributor

Fixes #1755

  • Option to allow the manager to create the CRD programatically if needed.
  • Fixes RBAC bug that createResources=true did not created needed RBAC

@seldondev
Copy link
Collaborator

Tue May 19 11:02:40 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1848/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1848 --build=1

@seldondev
Copy link
Collaborator

Tue May 19 11:02:57 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1848/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1848 --build=2

@ukclivecox ukclivecox changed the title WIP: CRD create on startup Optionally allow manager to create CRD May 19, 2020
@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue May 19 13:00:48 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1848/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1848 --build=3

@seldondev
Copy link
Collaborator

Tue May 19 13:01:05 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1848/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1848 --build=4

@seldondev
Copy link
Collaborator

Tue May 19 13:01:58 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1848/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1848 --build=5

@seldondev
Copy link
Collaborator

Thu May 28 07:56:05 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1848/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1848 --build=6

@seldondev
Copy link
Collaborator

Thu May 28 07:56:21 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1848/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1848 --build=7

@ukclivecox ukclivecox requested a review from axsaucedo May 28, 2020 10:15
@axsaucedo
Copy link
Contributor

All looks good and seems to work! Seems to be some merge conflicts - btw may be worth also adding an entry into the installing.md docs page where we talk about installing seldon with helm namely as we already document some of the options - would also be good to add the descriptions to the helm chart seldon-core-operator values.yaml as that file is referenced in the docs, we can do that in a follow-up PR for docs
/appove

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor Author

/hold

@seldondev
Copy link
Collaborator

Sun May 31 07:51:34 UTC 2020
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1848/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1848 --build=10

@seldondev
Copy link
Collaborator

Sun May 31 07:54:50 UTC 2020
The logs for [lint] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1848/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1848 --build=11

@ukclivecox
Copy link
Contributor Author

/hold cancel

@ukclivecox ukclivecox merged commit 4ac3a45 into SeldonIO:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCP Marketplace Update CRD Create
3 participants