Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headers to curl request for executor sample #1771

Merged
merged 1 commit into from
May 7, 2020

Conversation

glindsell
Copy link
Contributor

Fixes #1770
Signed-off-by: glindsell [email protected]

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: glindsell

If they are not already assigned, you can assign the PR to them by writing /assign @glindsell in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Thu Apr 30 14:03:57 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1771/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1771 --build=2

@seldondev
Copy link
Collaborator

Thu Apr 30 14:04:14 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1771/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1771 --build=1

@glindsell
Copy link
Contributor Author

/retest

@seldondev
Copy link
Collaborator

Thu Apr 30 14:35:18 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1771/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1771 --build=3

@glindsell
Copy link
Contributor Author

@ryandawsonuk I spoke to @cliveseldon about this one - he suggested you might have worked on this area of SC before. Do you know if this is expected behaviour that we force the client to specify the Content-Type in the Header of a request? Or should there be logic to work out what the Content-Type is from the payload?

@RafalSkolasinski
Copy link
Contributor

RafalSkolasinski commented May 1, 2020

Isn't requesting Conte-Type to be application/json just a web standard (when json is expected ofc)?
When sending requests from Python if you specify your post data using json=... argument in requests it adds that automatically for example.

@ukclivecox ukclivecox merged commit dbc55c4 into SeldonIO:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics executor local sample REST request fails
4 participants