Fix: Parse image name and version from env

[Ogaday]

Came across this bug, thought it would be helpful if I could fix it. Open to feedback on implementation, testing, naming, etc. I would have put the function in utils, but that would have caused a circular dependency.

Also seems like there's some duplication in the metadata and metrics modules, but I didn't want to overstep.

Fixes #1756

[seldondev]

Hi @Ogaday. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[RafalSkolasinski]

/ok-to-test

[RafalSkolasinski]

/test integration

[seldondev]

Mon Apr 27 19:39:58 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1757/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1757 --build=2

[seldondev]

Mon Apr 27 19:40:01 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1757/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1757 --build=3

[seldondev]

Mon Apr 27 19:40:03 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1757/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1757 --build=1

[RafalSkolasinski]

Hey, thanks a lot for this!

Sorry for causing trouble in the first place with the issue.
I guess it was my fault in recent metadata/metrics additions.

Could you please fix the linter issue? There is make target run_linter in python folder that will help.

Regarding the duplication and circular dependency - could you open another issue for that?
Then I think this could go as it is unless there will some comments from others.

[RafalSkolasinski]

/lgtm

[seldondev]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RafalSkolasinski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RafalSkolasinski]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[seldondev]

Tue Apr 28 08:23:33 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1757/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1757 --build=4

[seldondev]

Tue Apr 28 08:23:33 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1757/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1757 --build=5

[Ogaday]

Sorry for causing trouble in the first place with the issue.
I guess it was my fault in recent metadata/metrics additions.

Not at all! Seldon seems like a really cool framework and I appreciate being able to help.

[seldondev]

failed to trigger Pull Request pipeline

• failed to create agent
• failed to calculate in repo config
• failed to load trigger config for repository SeldonIO/seldon-core for ref 45f8733
• failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha 45f8733
• failed to process repo SeldonIO/seldon-core refref 45f8733
• failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
• open /var/tmp/gitrepo660600678/.lighthouse
• no such file or directory