Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info-log seldon-core version on microservice start #1751

Merged
merged 2 commits into from
May 30, 2020
Merged

info-log seldon-core version on microservice start #1751

merged 2 commits into from
May 30, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Apr 27, 2020

Fixes #1718
Closes #1704

But I wonder if maybe we could also log the git commit hash additionally to have it 100% clear what version are users running when they submit logs.

EDIT: actually we only have problem in distinguishing different 1.1.0-SNAPSHOT for example.
If someone will use dated build we will have a clear version. Still my preference would be to version using git hashes but this will correctly leverage existing mechanism.

Edit 2: test added in this PR will also avoid in future problems reported in #1718

@seldondev
Copy link
Collaborator

Mon Apr 27 09:26:45 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1751/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1751 --build=1

@seldondev
Copy link
Collaborator

Mon Apr 27 09:26:58 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1751/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1751 --build=2

@seldondev
Copy link
Collaborator

Mon Apr 27 09:29:50 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1751/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1751 --build=4

@seldondev
Copy link
Collaborator

Mon Apr 27 09:29:52 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1751/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1751 --build=3

@seldondev
Copy link
Collaborator

Mon Apr 27 09:40:37 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1751/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1751 --build=5

@seldondev
Copy link
Collaborator

Mon Apr 27 09:40:42 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1751/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1751 --build=6

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu May 7 10:01:15 UTC 2020
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1751/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1751 --build=7

@seldondev
Copy link
Collaborator

Wed May 27 10:29:20 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1751/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1751 --build=8

@seldondev
Copy link
Collaborator

Wed May 27 10:29:28 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1751/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1751 --build=9

@seldondev
Copy link
Collaborator

Thu May 28 10:31:27 UTC 2020
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1751/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1751 --build=10

@seldondev
Copy link
Collaborator

Thu May 28 10:33:29 UTC 2020
The logs for [lint] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1751/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1751 --build=11

@seldondev
Copy link
Collaborator

Thu May 28 10:34:39 UTC 2020
The logs for [lint] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1751/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1751 --build=13

@seldondev
Copy link
Collaborator

Thu May 28 10:34:41 UTC 2020
The logs for [pr-build] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1751/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1751 --build=12

@axsaucedo
Copy link
Contributor

Very useful, I assumed this was already in release.py, definitely good to make sure is there, and test will make sure versions are aligned, looks good!
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Sat May 30 16:48:54 UTC 2020
The logs for [lint] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1751/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1751 --build=15

@seldondev
Copy link
Collaborator

Sat May 30 16:49:20 UTC 2020
The logs for [pr-build] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1751/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1751 --build=14

@seldondev seldondev merged commit 2a9a360 into SeldonIO:master May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants