-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
info-log seldon-core version on microservice start #1751
info-log seldon-core version on microservice start #1751
Conversation
Mon Apr 27 09:26:45 UTC 2020 impatient try |
Mon Apr 27 09:26:58 UTC 2020 impatient try |
Mon Apr 27 09:29:50 UTC 2020 impatient try |
Mon Apr 27 09:29:52 UTC 2020 impatient try |
Mon Apr 27 09:40:37 UTC 2020 impatient try |
Mon Apr 27 09:40:42 UTC 2020 impatient try |
/test integration |
Thu May 7 10:01:15 UTC 2020 impatient try |
Wed May 27 10:29:20 UTC 2020 impatient try |
Wed May 27 10:29:28 UTC 2020 impatient try |
Thu May 28 10:31:27 UTC 2020 impatient try |
Thu May 28 10:33:29 UTC 2020 impatient try |
Thu May 28 10:34:39 UTC 2020 impatient try |
Thu May 28 10:34:41 UTC 2020 impatient try |
Very useful, I assumed this was already in release.py, definitely good to make sure is there, and test will make sure versions are aligned, looks good! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sat May 30 16:48:54 UTC 2020 impatient try |
Sat May 30 16:49:20 UTC 2020 impatient try |
Fixes #1718
Closes #1704
But I wonder if maybe we could also log the git commit hash additionally to have it 100% clear what version are users running when they submit logs.
EDIT: actually we only have problem in distinguishing different
1.1.0-SNAPSHOT
for example.If someone will use dated build we will have a clear version. Still my preference would be to version using git hashes but this will correctly leverage existing mechanism.
Edit 2: test added in this PR will also avoid in future problems reported in #1718