-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swagger UI with Embedded Seldon Deployment Values #1744
Swagger UI with Embedded Seldon Deployment Values #1744
Conversation
…he model is hosted
Sun Apr 26 14:54:36 UTC 2020 impatient try |
Sun Apr 26 14:54:41 UTC 2020 impatient try |
Hmm strange, it seems the test failure is on /test all |
Sun Apr 26 15:44:32 UTC 2020 impatient try |
Sun Apr 26 15:44:37 UTC 2020 impatient try |
Sun Apr 26 15:44:39 UTC 2020 impatient try |
Sun Apr 26 15:44:49 UTC 2020 impatient try |
/test notebooks |
Sun Apr 26 17:45:12 UTC 2020 impatient try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! I've added a couple comments below, but I think this looks great!
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thu Apr 30 09:52:46 UTC 2020 impatient try |
Thu Apr 30 09:52:51 UTC 2020 impatient try |
@axsaucedo: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Failed test is |
Thu Apr 30 10:21:40 UTC 2020 impatient try |
Thu Apr 30 19:28:43 UTC 2020 impatient try |
Thu Apr 30 19:28:52 UTC 2020 impatient try |
PR includes: