Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(executor): Update proto compilation and package versions #1681

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

groszewn
Copy link
Contributor

Updates the compile_seldon_proto rule to place the updated protobuf in
the correct location, along with correcting the package name and
updating the grpc package version to work with newer versions of the
proto compiler.

Addresses #1663

Signed off by Nick Groszewski ([email protected])

Updates the `compile_seldon_proto` rule to place the updated protobuf in
the correct location, along with correcting the package name and
updating the grpc package version to work with newer versions of the
proto compiler.

Addresses SeldonIO#1663

Signed off by Nick Groszewski (<[email protected]>)
@seldondev
Copy link
Collaborator

Hi @groszewn. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@groszewn
Copy link
Contributor Author

@cliveseldon Opened based off of our conversation in the Custom protobuf support PR

@groszewn
Copy link
Contributor Author

/assign @cliveseldon

@groszewn
Copy link
Contributor Author

@cliveseldon just wanted to check in and see if you had any feedback based off of Custom protobuf support PR.

@axsaucedo
Copy link
Contributor

/ok-to-test

@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo
Copy link
Contributor

Thank you @groszewn we'll merge this one first so the other one can go first. Looks good so we'll be able to land once the integration tests pass (excluding some flaky ones)

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Mon Apr 20 13:46:21 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1681/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1681 --build=2

@seldondev
Copy link
Collaborator

Mon Apr 20 13:46:22 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1681/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1681 --build=3

@seldondev
Copy link
Collaborator

Mon Apr 20 13:46:26 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1681/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1681 --build=1

@seldondev seldondev merged commit 34ab0c3 into SeldonIO:master Apr 20, 2020
@groszewn groszewn deleted the grpc_updates branch April 21, 2020 01:56
@seldondev
Copy link
Collaborator

failed to trigger Pull Request pipeline

  • failed to create agent
  • failed to calculate in repo config
  • failed to load trigger config for repository SeldonIO/seldon-core for ref f319010
  • failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha f319010
  • failed to process repo SeldonIO/seldon-core refref f319010
  • failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
  • open /var/tmp/gitrepo660600678/.lighthouse
  • no such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants