Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for virtualservices before running clean up #1632

Merged
merged 1 commit into from
Mar 29, 2020
Merged

check for virtualservices before running clean up #1632

merged 1 commit into from
Mar 29, 2020

Conversation

ukclivecox
Copy link
Contributor

Fixes #1631

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cliveseldon

If they are not already assigned, you can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Sun Mar 29 16:36:15 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1632/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1632 --build=2

@seldondev
Copy link
Collaborator

Sun Mar 29 16:36:16 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1632/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1632 --build=1

@ukclivecox ukclivecox merged commit d21f34f into SeldonIO:master Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up of VirtualServices active for non-istio scenarios
2 participants