Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation page on local testing #1586

Merged
merged 2 commits into from
Mar 23, 2020

Conversation

axsaucedo
Copy link
Contributor

@axsaucedo axsaucedo commented Mar 23, 2020

Added documentation page on local testing and fixed some other pieces on the docs.

Also added a link ot the python module from the Getting Started index for easier access as right now it's hard to find given it's only accessible through teh python wrapper section.

@axsaucedo axsaucedo requested a review from ukclivecox March 23, 2020 17:19
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: axsaucedo

If they are not already assigned, you can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Mon Mar 23 17:20:49 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1586/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1586 --build=2

@seldondev
Copy link
Collaborator

Mon Mar 23 17:21:03 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1586/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1586 --build=1

@axsaucedo
Copy link
Contributor Author

/approve

@axsaucedo axsaucedo merged commit 69dc196 into SeldonIO:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants