Update explainer path for Ambassador #1585
Conversation
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
|
Mon Mar 23 16:30:43 UTC 2020 impatient try |
|
Mon Mar 23 16:30:48 UTC 2020 impatient try |
| serviceNameExternal = nameOverride | ||
| if isExplainer { | ||
| name = name + constants.ExplainerNameSuffix | ||
| serviceNameExternal = serviceNameExternal + constants.ExplainerPathSuffix |
There was a problem hiding this comment.
May be better to join with path.Join(..) ?
There was a problem hiding this comment.
Quite minor as the above is still with dash anyways
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cliveseldon there seems to be some merge conflicts |
|
New changes are detected. LGTM label has been removed. |
|
Wed Mar 25 10:10:35 UTC 2020 impatient try |
|
Wed Mar 25 10:12:01 UTC 2020 impatient try |
|
Wed Mar 25 17:50:30 UTC 2020 impatient try |
|
Wed Mar 25 17:50:41 UTC 2020 impatient try |
|
/test this |
|
/test lint |
|
Thu Mar 26 10:43:09 UTC 2020 impatient try |
|
Thu Mar 26 10:43:22 UTC 2020 impatient try |
Fixes #1548