Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all labels and annotations added to created deployments #1580

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Ensure all labels and annotations added to created deployments #1580

merged 2 commits into from
Mar 26, 2020

Conversation

ukclivecox
Copy link
Contributor

Fixes #1561

@seldondev
Copy link
Collaborator

Mon Mar 23 11:30:01 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1580/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1580 --build=1

@seldondev
Copy link
Collaborator

Mon Mar 23 11:30:03 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1580/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1580 --build=2

Copy link
Contributor

@ryandawsonuk ryandawsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@seldondev seldondev removed the lgtm label Mar 24, 2020
@seldondev
Copy link
Collaborator

Tue Mar 24 17:12:10 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1580/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1580 --build=4

@seldondev
Copy link
Collaborator

Tue Mar 24 17:12:14 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1580/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1580 --build=3

@seldondev
Copy link
Collaborator

Tue Mar 24 17:33:46 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1580/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1580 --build=6

@seldondev
Copy link
Collaborator

Tue Mar 24 17:33:49 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1580/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1580 --build=5

@axsaucedo
Copy link
Contributor

@cliveseldon @ryandawsonuk seems PR build is failing

@ukclivecox
Copy link
Contributor Author

/test this

@seldondev
Copy link
Collaborator

Wed Mar 25 20:23:24 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1580/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1580 --build=7

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

Thu Mar 26 08:55:33 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1580/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1580 --build=9

@seldondev
Copy link
Collaborator

Thu Mar 26 08:55:40 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1580/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1580 --build=8

@axsaucedo
Copy link
Contributor

/lgtm

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo, ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [axsaucedo,ryandawsonuk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox ukclivecox merged commit 24e0f57 into SeldonIO:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add labels from componentSpecs.metadata to dpeloyments
4 participants