-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Events and fix State for SeldonDeployments #1570
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sat Mar 21 08:38:08 UTC 2020 impatient try |
Sat Mar 21 08:38:17 UTC 2020 impatient try |
/test integration |
Sat Mar 21 09:35:27 UTC 2020 impatient try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I just added two questions to clarify
Sat Mar 21 15:47:52 UTC 2020 impatient try |
Sat Mar 21 15:48:04 UTC 2020 impatient try |
Sat Mar 21 15:49:51 UTC 2020 impatient try |
Sat Mar 21 15:49:51 UTC 2020 impatient try |
/test integration |
Sat Mar 21 15:53:16 UTC 2020 impatient try |
/test integration |
Sat Mar 21 17:08:15 UTC 2020 impatient try |
/test integration |
Sun Mar 22 08:22:28 UTC 2020 impatient try |
Sun Mar 22 09:48:11 UTC 2020 impatient try |
Sun Mar 22 09:48:20 UTC 2020 impatient try |
/test integration |
Sun Mar 22 10:03:57 UTC 2020 impatient try |
@cliveseldon: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fixes #1560
Failed
andDescription
set if Reconcile failsSuccessful deployment
Failed deployment