Move protocol/transport CRD variables

[ukclivecox]

Fixes #1552

• Move protocol and transport CRD variables from predictor to deploymentSpec as they should be global to the deployed graph.

Also fixes some small bugs:

• Ensures the cpu/memory resource requests/limits for manager are generated for helm template from the kustomize in split_resources.py
• Removes EXECUTOR_REQUEST_LOGGER_DEFAULT_ENDPOINT and adds EXECUTOR_REQUEST_LOGGER_DEFAULT_ENDPOINT_PREFIX to kustomize and updates split_resources.py to ensure they are generated in Helm template

[seldondev]

Tue Mar 17 08:54:28 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1553/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1553 --build=2

[seldondev]

Tue Mar 17 08:55:53 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1553/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1553 --build=1

[seldondev]

Tue Mar 17 16:16:58 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1553/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1553 --build=3

[seldondev]

Tue Mar 17 16:17:12 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1553/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1553 --build=4

[ryandawsonuk]

@axsaucedo you happy with the changes or otherwise happy for me to pick up the review on this? Looking to get it through for something I'm working on

[axsaucedo]

@ryandawsonuk looks good! LEt me just test once again locally and will approve once I confirm

[axsaucedo]

/lgtm
/approve

[seldondev]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [axsaucedo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[seldondev]

Tue Mar 17 18:25:27 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1553/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1553 --build=5

[seldondev]

Tue Mar 17 18:25:30 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1553/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1553 --build=6