HPA scaleTargetRef apiVersion should be consistent with Deployments

[ahutterTA]

Fixes #1533

[seldondev]

Hi @ahutterTA. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ahutterTA]

Should fix #1533

[ahutterTA]

/assign @adriangonz

[axsaucedo]

Awesome
/ok-to-test

[seldondev]

Wed Mar 11 22:00:00 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1534/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1534 --build=2

[seldondev]

Wed Mar 11 22:00:01 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1534/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1534 --build=1

[axsaucedo]

/cc @adriangonz
/cc @cliveseldon

[adriangonz]

/test integration
/approve

Looks good! Thanks @ahutterTA! We should be good to merge it once the integration tests pass.

[seldondev]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adriangonz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[seldondev]

Thu Mar 12 08:46:00 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1534/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1534 --build=3

[seldondev]

@ahutterTA: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
integration	a45e0c0	link	/test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[adriangonz]

There were a couple errors on the new notebooks tests in TestNotebooks.test_explainer_examples and TestNotebooks.test_server_examples. Everything else passed fine.

I don't think these are related to the PR changes though. What are your thoughts @cliveseldon?