Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change explainer to pointer reference in api types #1497

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Change explainer to pointer reference in api types #1497

merged 1 commit into from
Mar 13, 2020

Conversation

ukclivecox
Copy link
Contributor

Fixes #1485

@seldondev
Copy link
Collaborator

Tue Mar 3 11:19:34 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1497/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1497 --build=2

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Mar 3 11:19:38 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1497/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1497 --build=1

@seldondev
Copy link
Collaborator

Tue Mar 3 11:21:00 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1497/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1497 --build=3

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Mar 3 15:36:33 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1497/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1497 --build=4

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Mar 3 17:40:08 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1497/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1497 --build=5

@adriangonz
Copy link
Contributor

/test integration

Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I think we can merge once the integration tests pass. The error seems to be coming from one of the flaky tests (see #1402), so it should be fine after retrying.

@seldondev
Copy link
Collaborator

Wed Mar 4 10:02:48 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1497/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1497 --build=6

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor Author

@adriangonz Trouble is different ones keep failing. Maybe we should increase flakiness attempts?

@seldondev
Copy link
Collaborator

@cliveseldon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 4d8d604 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ukclivecox ukclivecox merged commit 05c76bb into SeldonIO:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change explainer type to pointer in go struct
3 participants