-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change explainer to pointer reference in api types #1497
Conversation
Tue Mar 3 11:19:34 UTC 2020 impatient try |
/test integration |
Tue Mar 3 11:19:38 UTC 2020 impatient try |
Tue Mar 3 11:21:00 UTC 2020 impatient try |
/test integration |
Tue Mar 3 15:36:33 UTC 2020 impatient try |
/test integration |
Tue Mar 3 17:40:08 UTC 2020 impatient try |
/test integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I think we can merge once the integration tests pass. The error seems to be coming from one of the flaky tests (see #1402), so it should be fine after retrying.
Wed Mar 4 10:02:48 UTC 2020 impatient try |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriangonz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@adriangonz Trouble is different ones keep failing. Maybe we should increase flakiness attempts? |
@cliveseldon: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fixes #1485