-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce flakiness on tracing tests #1488
Conversation
/test integration |
Thu Feb 27 17:56:39 UTC 2020 impatient try |
Thu Feb 27 17:56:48 UTC 2020 impatient try |
Thu Feb 27 17:57:37 UTC 2020 impatient try |
/test integration |
Fri Feb 28 09:15:11 UTC 2020 impatient try |
/test integration |
Fri Feb 28 11:03:37 UTC 2020 impatient try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriangonz, RafalSkolasinski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Mon Mar 9 14:48:33 UTC 2020 impatient try |
Mon Mar 9 14:48:35 UTC 2020 impatient try |
Context
Jaeger processes the tracing spans asynchronously, so there is a slight delay between an action happening and Jaeger reporting the full trace. Because of this, the integration tests introduced in #1464 may fail some times (when we fetch the requests while not all of them have been processed yet).
Changelog