Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce flakiness on tracing tests #1488

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

adriangonz
Copy link
Contributor

Context

Jaeger processes the tracing spans asynchronously, so there is a slight delay between an action happening and Jaeger reporting the full trace. Because of this, the integration tests introduced in #1464 may fail some times (when we fetch the requests while not all of them have been processed yet).

Changelog

  • Retry Jaeger tracing request if the trace seems incomplete.

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu Feb 27 17:56:39 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1488/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1488 --build=1

@seldondev
Copy link
Collaborator

Thu Feb 27 17:56:48 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1488/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1488 --build=2

@seldondev
Copy link
Collaborator

Thu Feb 27 17:57:37 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1488/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1488 --build=3

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Fri Feb 28 09:15:11 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1488/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1488 --build=4

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Fri Feb 28 11:03:37 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1488/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1488 --build=5

@adriangonz
Copy link
Contributor Author

/cc @RafalSkolasinski

Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@RafalSkolasinski
Copy link
Contributor

/lgtm
/approve

@adriangonz
Copy link
Contributor Author

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz, RafalSkolasinski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Mon Mar 9 14:48:33 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1488/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1488 --build=7

@seldondev
Copy link
Collaborator

Mon Mar 9 14:48:35 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1488/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1488 --build=6

@seldondev seldondev merged commit 8899aad into SeldonIO:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants