Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove benchmark notebook #1473

Merged
merged 5 commits into from
Feb 27, 2020
Merged

Conversation

glindsell
Copy link
Contributor

@glindsell glindsell commented Feb 21, 2020

Fixes #1455

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@seldondev
Copy link
Collaborator

Fri Feb 21 10:36:17 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1473/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1473 --build=2

@seldondev
Copy link
Collaborator

Fri Feb 21 10:37:45 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1473/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1473 --build=1

@glindsell glindsell requested a review from ukclivecox February 21, 2020 11:18
@ukclivecox
Copy link
Contributor

/approve

Copy link
Contributor

@ryandawsonuk ryandawsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon, ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cliveseldon,ryandawsonuk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Thu Feb 27 11:13:11 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1473/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1473 --build=4

@seldondev
Copy link
Collaborator

Thu Feb 27 11:13:22 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1473/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1473 --build=3

@seldondev seldondev merged commit 1cc1e9b into SeldonIO:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove benchmark_simple_model notebook
4 participants