Use flake8 to find syntax errors and undefined names

[cclauss]

These tests find the problems described in #1441 and #1442

[seldondev]

Hi @cclauss. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adriangonz]

Thanks for your contribution @cclauss! Adding flake8 on top of black makes a lot of sense.

I've added a couple small comments to move some of the hardcoded bits from the jenkins-x-lint.yaml into requirements-dev.txt and setup.cfg. Would you be able to address these whenever you have a chance?

[adriangonz]

/ok-to-test

Awesome! Thanks for updating the PR @cclauss !

[seldondev]

Mon Feb 17 12:22:49 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1443/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1443 --build=1

[seldondev]

Mon Feb 17 12:22:57 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1443/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1443 --build=2

[cclauss]

We might be missing pip install -r python/requirements-dev.txt

[seldondev]

Mon Feb 17 12:29:51 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1443/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1443 --build=3

[adriangonz]

I think that the install is running in parallel to the linting step.

[seldondev]

Mon Feb 17 13:36:49 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1443/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1443 --build=5

[adriangonz]

/test this

[adriangonz]

/test lint

[seldondev]

Mon Feb 17 13:54:26 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1443/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1443 --build=7

[seldondev]

Mon Feb 17 14:51:48 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1443/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1443 --build=9

[seldondev]

Mon Feb 17 14:54:56 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1443/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1443 --build=11

[seldondev]

Mon Feb 17 14:54:59 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1443/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1443 --build=12

[seldondev]

Mon Feb 17 15:01:08 UTC 2020
The logs for [lint] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1443/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1443 --build=14

[seldondev]

Mon Feb 17 15:02:30 UTC 2020
The logs for [pr-build] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1443/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1443 --build=13

[seldondev]

Mon Feb 17 15:16:00 UTC 2020
The logs for [pr-build] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1443/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1443 --build=15

[seldondev]

Mon Feb 17 15:19:13 UTC 2020
The logs for [lint] [20] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1443/20.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1443 --build=20

[seldondev]

Mon Feb 17 15:19:14 UTC 2020
The logs for [pr-build] [19] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1443/19.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1443 --build=19

[adriangonz]

Sorry for the back and forth @cclauss. I think that the right keyword was stages (instead of steps) and there were also a couple other weird issues with the Jenkins X pipeline format.

I've jumped in to fix those and to flatten the linting steps. It now seems to be running flake8 and is happy!

If you are happy with the changes, I think we can merge this one.

[cclauss]

I am happy if you are.

[adriangonz]

/approve

Awesome! Thanks for contributing this piece @cclauss !

[seldondev]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adriangonz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment