-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add example for custom metrics in feedback #1366
Conversation
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fri Jan 24 14:33:40 UTC 2020 impatient try |
Fri Jan 24 14:33:53 UTC 2020 impatient try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just make sure to add the nblink and jupyter reference in the docs.
/approve @axsaucedo that should be already there in https://docs.seldon.io/projects/seldon-core/en/latest/examples/tmpl_model_with_metrics.html From my side the only change would be to move it to Kind, but I realise that's outside the scope of this issue and should be tackled as part of #1256 instead. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriangonz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriangonz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Mon Jan 27 14:16:13 UTC 2020 impatient try |
Mon Jan 27 14:16:26 UTC 2020 impatient try |
failed to trigger Pull Request pipeline
|
This adds example related to issue #315