Bump okhttp from 4.2.2 to 4.3.0 in /engine #1314

dependabot-preview · 2020-01-06T07:37:27Z

Bumps okhttp from 4.2.2 to 4.3.0.

Changelog

Version 4.3.0

2019-12-31

Fix: Degrade HTTP/2 connections after a timeout. When an HTTP/2 stream times out it may impact the stream only or the entire connection. With this fix OkHttp will now send HTTP/2 pings after a stream timeout to determine whether the connection should remain eligible for pooling.

Fix: Don't call EventListener.responseHeadersStart() or responseBodyStart() until bytes have been received. Previously these events were incorrectly sent too early, when OkHttp was ready to read the response headers or body, which mislead tracing tools. Note that the responseFailed() event always used to follow one of these events; now it may be sent without them.

New: Upgrade to Kotlin 1.3.61.

New: Match any number of subdomains with two asterisks in CertificatePinner. For example, **.squareup.com matches us-west.www.squareup.com, www.squareup.com and squareup.com.

New: Share threads more aggressively between OkHttp's HTTP/2 connections, connection pool, web sockets, and cache. OkHttp has a new internal task runner abstraction for managed task scheduling. In your debugger you will see new thread names and more use of daemon threads.

Fix: Don't drop callbacks on unexpected exceptions. When an interceptor throws an unchecked exception the callback is now notified that the call was canceled. The exception is still sent to the uncaught exception handler for reporting and recovery.

Fix: Un-deprecate MockResponse.setHeaders() and other setters. These were deprecated in OkHttp 4.0 but that broke method chaining for Java callers.

Fix: Don't crash on HTTP/2 HEAD requests when the Content-Length header is present but is not consistent with the length of the response body.

Fix: Don't crash when converting a HttpUrl instance with an unresolvable hostname to a URI. The new behavior strips invalid characters like " and { from the hostname before converting.

Fix: Undo a performance regression introduced in OkHttp 4.0 caused by differences in behavior between Kotlin's assert() and Java's assert(). (Kotlin always evaluates the argument; Java only does when assertions are enabled.)

Fix: Honor RequestBody.isOneShot() in HttpLoggingInterceptor.

Commits

b63debd Prepare for release 4.3.0.
b2b2dd7 Merge pull request #5676 from square/jwilson.1231.restore_chaining
a2c0607 Un-deprecate some setters for chaining from Java
bf85d1b Merge pull request #5195 from square/fix-content-length-of-http2-response-body
62cf6c2 Merge pull request #5674 from square/jwilson.1231.strip
bd675a8 Merge pull request #5671 from square/jwilson.1230.debug_logging
a815093 Document debug logging.
283418b Fix a crash in HttpUrl.toUri().
b9e0422 Merge pull request #5672 from square/jwilson.1230.await_idle
edb5865 Fix crash on repeated MockWebServer shutdown
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

Update frequency
Out-of-range updates (receive only lockfile updates, if desired)
Security updates (receive only security updates, if desired)

Bumps [okhttp](https://github.com/square/okhttp) from 4.2.2 to 4.3.0. - [Release notes](https://github.com/square/okhttp/releases) - [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md) - [Commits](square/okhttp@parent-4.2.2...parent-4.3.0) Signed-off-by: dependabot-preview[bot] <[email protected]>

seldondev · 2020-01-06T07:37:51Z

Hi @dependabot-preview[bot]. Thanks for your PR.

I'm waiting for a SeldonIO or seldonio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dependabot-preview · 2020-01-07T15:15:22Z

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

adriangonz · 2020-01-07T15:15:30Z

/ok-to-test

seldondev · 2020-01-07T15:17:07Z

Tue Jan 7 15:17:06 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1314/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1314 --build=1

seldondev · 2020-01-07T15:17:26Z

Tue Jan 7 15:17:25 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1314/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1314 --build=4

seldondev · 2020-01-07T15:17:27Z

Tue Jan 7 15:17:26 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1314/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1314 --build=3

seldondev · 2020-01-07T15:18:32Z

Tue Jan 7 15:18:30 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1314/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1314 --build=2

adriangonz · 2020-01-07T15:41:00Z

/test integration

seldondev · 2020-01-07T15:42:13Z

Tue Jan 7 15:42:11 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1314/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1314 --build=5

adriangonz · 2020-01-08T09:35:58Z

/test integration

seldondev · 2020-01-08T09:37:20Z

Wed Jan 8 09:37:19 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1314/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1314 --build=6

adriangonz · 2020-01-08T11:22:40Z

It seems that the integration tests fail because Istio didn't get installed (we timed out waiting for it to come up). When this fails, Seldon Core also doesn't get installed so all the tests fail.

adriangonz · 2020-01-08T11:22:52Z

/uncc @cliveseldon @ryandawsonuk

adriangonz · 2020-01-09T09:31:33Z

/test integration

seldondev · 2020-01-09T09:32:46Z

Thu Jan 9 09:32:45 UTC 2020
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1314/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1314 --build=7

seldondev · 2020-01-09T09:56:19Z

@dependabot-preview[bot]: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
integration	`6d6fc57`	link	`/test integration`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

adriangonz · 2020-01-09T10:51:19Z

/approve

The only failing test is an intermittent 503 while testing rolling updates.

seldondev · 2020-01-09T10:51:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [adriangonz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dependabot-preview bot added dependencies Pull requests that update a dependency file Java labels Jan 6, 2020

seldondev requested review from ukclivecox and ryandawsonuk January 6, 2020 07:37

seldondev added size/XS needs-ok-to-test labels Jan 6, 2020

adriangonz closed this Jan 7, 2020

adriangonz reopened this Jan 7, 2020

seldondev added ok-to-test and removed needs-ok-to-test labels Jan 7, 2020

seldondev removed request for ukclivecox and ryandawsonuk January 8, 2020 11:22

adriangonz merged commit b300110 into master Jan 9, 2020

seldondev added the approved label Jan 9, 2020

adriangonz deleted the dependabot/maven/engine/com.squareup.okhttp3-okhttp-4.3.0 branch January 9, 2020 10:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump okhttp from 4.2.2 to 4.3.0 in /engine #1314

Bump okhttp from 4.2.2 to 4.3.0 in /engine #1314

dependabot-preview bot commented Jan 6, 2020

seldondev commented Jan 6, 2020

dependabot-preview bot commented Jan 7, 2020

adriangonz commented Jan 7, 2020

seldondev commented Jan 7, 2020

seldondev commented Jan 7, 2020

seldondev commented Jan 7, 2020

seldondev commented Jan 7, 2020

adriangonz commented Jan 7, 2020

seldondev commented Jan 7, 2020

adriangonz commented Jan 8, 2020

seldondev commented Jan 8, 2020

adriangonz commented Jan 8, 2020

adriangonz commented Jan 8, 2020

adriangonz commented Jan 9, 2020

seldondev commented Jan 9, 2020

seldondev commented Jan 9, 2020

adriangonz commented Jan 9, 2020

seldondev commented Jan 9, 2020

Bump okhttp from 4.2.2 to 4.3.0 in /engine #1314

Bump okhttp from 4.2.2 to 4.3.0 in /engine #1314

Conversation

dependabot-preview bot commented Jan 6, 2020

Version 4.3.0

seldondev commented Jan 6, 2020

dependabot-preview bot commented Jan 7, 2020

adriangonz commented Jan 7, 2020

seldondev commented Jan 7, 2020

seldondev commented Jan 7, 2020

seldondev commented Jan 7, 2020

seldondev commented Jan 7, 2020

adriangonz commented Jan 7, 2020

seldondev commented Jan 7, 2020

adriangonz commented Jan 8, 2020

seldondev commented Jan 8, 2020

adriangonz commented Jan 8, 2020

adriangonz commented Jan 8, 2020

adriangonz commented Jan 9, 2020

seldondev commented Jan 9, 2020

seldondev commented Jan 9, 2020

adriangonz commented Jan 9, 2020

seldondev commented Jan 9, 2020