Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ambassador Weight Assignments #1268

Closed
wants to merge 3 commits into from
Closed

Fix Ambassador Weight Assignments #1268

wants to merge 3 commits into from

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented Dec 13, 2019

  • Seems to also fix the 404s in rolling updates. run several hundred tests with zero failures locally.

Fixes #1271

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cliveseldon

If they are not already assigned, you can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Dec 13 19:26:13 UTC 2019
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1268/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1268 --build=2

@seldondev
Copy link
Collaborator

Fri Dec 13 19:26:23 UTC 2019
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1268/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1268 --build=1

@ukclivecox ukclivecox self-assigned this Dec 14, 2019
@ukclivecox
Copy link
Contributor Author

/ok-to-test

@seldondev
Copy link
Collaborator

Sat Dec 14 09:26:02 UTC 2019
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1268/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1268 --build=3

@seldondev
Copy link
Collaborator

Sat Dec 14 09:26:07 UTC 2019
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1268/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1268 --build=4

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Sat Dec 14 09:27:04 UTC 2019
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1268/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1268 --build=5

@seldondev
Copy link
Collaborator

Sat Dec 14 09:27:12 UTC 2019
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1268/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1268 --build=6

@seldondev
Copy link
Collaborator

Sat Dec 14 09:28:18 UTC 2019
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1268/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1268 --build=7

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Sat Dec 14 10:22:49 UTC 2019
The logs for [integration] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1268/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1268 --build=8

@ukclivecox
Copy link
Contributor Author

Closing as working on wider fix for this and hpas

@ukclivecox ukclivecox closed this Dec 14, 2019
@ukclivecox ukclivecox deleted the rolling_update_test branch February 14, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambassador 404s on Canary Test
2 participants