Add versions v1 and v1alpha3 to CRD #1229
Conversation
|
Tue Dec 10 09:54:45 UTC 2019 impatient try |
|
Tue Dec 10 09:54:50 UTC 2019 impatient try |
adriangonz
force-pushed
the
upgrade-crd-v1
branch
from
7aed3d5 to
fa162ec
Compare
|
Tue Dec 10 15:30:32 UTC 2019 impatient try |
|
Tue Dec 10 15:30:53 UTC 2019 impatient try |
adriangonz
force-pushed
the
upgrade-crd-v1
branch
from
dcb1589 to
c71c725
Compare
|
Tue Dec 10 17:57:25 UTC 2019 impatient try |
|
Tue Dec 10 17:57:39 UTC 2019 impatient try |
|
Wed Dec 11 09:19:31 UTC 2019 impatient try |
|
Wed Dec 11 09:19:37 UTC 2019 impatient try |
adriangonz
force-pushed
the
upgrade-crd-v1
branch
from
ee0ec1e to
7cf3a40
Compare
|
Wed Dec 11 13:29:45 UTC 2019 impatient try |
|
Wed Dec 11 13:29:46 UTC 2019 impatient try |
|
Wed Dec 11 14:43:29 UTC 2019 impatient try |
|
Wed Dec 11 14:43:45 UTC 2019 impatient try |
|
Wed Dec 11 17:40:13 UTC 2019 impatient try |
|
Wed Dec 11 17:40:20 UTC 2019 impatient try |
|
/test integration |
|
Wed Dec 11 17:49:16 UTC 2019 impatient try |
adriangonz
changed the title
|
Wed Dec 11 18:23:58 UTC 2019 impatient try |
|
Wed Dec 11 18:24:01 UTC 2019 impatient try |
|
/test integration |
|
Wed Dec 11 18:30:18 UTC 2019 impatient try |
|
/cc @axsaucedo @ryandawsonuk @cliveseldon If the integration tests pass, I think this is good to go now. I've added a couple of tests checking that:
|
|
Wed Dec 11 20:57:21 UTC 2019 impatient try |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test integration |
|
Thu Dec 12 09:08:20 UTC 2019 impatient try |
|
/retest |
|
Thu Dec 12 09:41:44 UTC 2019 impatient try |
|
So the previous run there was 1 failure and this run (with no code changes) there are 2 |
|
The 504 is on test_rolling_update5 both times |
adriangonz
force-pushed
the
upgrade-crd-v1
branch
from
bc42d1f to
645a1e1
Compare
|
Fri Dec 13 10:50:03 UTC 2019 impatient try |
|
Fri Dec 13 10:50:09 UTC 2019 impatient try |
|
/test integration |
|
Fri Dec 13 10:54:01 UTC 2019 impatient try |
|
@adriangonz: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fixes #890.
Fixes #1100.
Changelog
v1andv1alpha3of CRD.v1as storage version.v1alpha2tov1.TODO
Reduce code duplication by importing fromv1(or from outside)We will raise this as a separate issue, which will involve refactoring the webhooks and types so that they can get imported in
v1alpha2andv1alpha3(fromv1).Note on webhooks
We only need to set up webhooks for the stored version. However, Seldon Core
0.4.1seems to usev1alpha3for storage and Seldon Core0.5.xusesv1alpha2for storage. Therefore, the webhooks for eachapiVersion(e.g./mutate-machinelearning-seldon-io-v1alpha2-seldondeployment) also need to be registered.This is necessary for the
SeldonDeploymentinstances to update fromv1alpha2+v1alpha3tov1.On a future version of Seldon Core (e.g.
1.1), we will be able to remove thev1alpha2andv1alpha3altogether. Or at least assume that they are not used for storage. This will enable us to unregister their respective webhooks.