Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1138 helm3 integration tests #1186

Merged

Conversation

glindsell
Copy link
Contributor

@glindsell glindsell commented Dec 3, 2019

#1138

(continued from #1181)

  • Updated Integration tests in line with Helm v3

  • Added to test README.md

@glindsell
Copy link
Contributor Author

/test integration

@glindsell glindsell requested review from ryandawsonuk and removed request for gsunner and gipster December 3, 2019 15:54
@glindsell
Copy link
Contributor Author

/test integration

@glindsell
Copy link
Contributor Author

/test integration

@glindsell
Copy link
Contributor Author

/retest

operator/go.mod Outdated
@@ -6,21 +6,16 @@ require (
github.com/Azure/go-autorest/autorest v0.9.2 // indirect
github.com/Azure/go-autorest/autorest/adal v0.7.0 // indirect
github.com/go-logr/logr v0.1.0
github.com/gogo/protobuf v1.2.1 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we revert the changes to the go.mod and go.sum dependencies of the operator? What triggered these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have merged with master and run go mod tidy

@ukclivecox ukclivecox added this to the 1.0 milestone Dec 5, 2019
@glindsell
Copy link
Contributor Author

/test integration

@glindsell
Copy link
Contributor Author

/retest

@seldondev
Copy link
Collaborator

Fri Dec 6 09:55:08 UTC 2019
The logs for [integration] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1186/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1186 --build=11

@seldondev
Copy link
Collaborator

Fri Dec 6 14:48:32 UTC 2019
The logs for [pr-build] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1186/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1186 --build=12

@seldondev
Copy link
Collaborator

Fri Dec 6 14:48:37 UTC 2019
The logs for [lint] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1186/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1186 --build=13

@glindsell
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Fri Dec 6 15:00:22 UTC 2019
The logs for [integration] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1186/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1186 --build=14

@ryandawsonuk
Copy link
Contributor

/lgtm
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ryandawsonuk ryandawsonuk merged commit f3b6711 into SeldonIO:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants