-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1138 helm3 integration tests #1186
1138 helm3 integration tests #1186
Conversation
Signed-off-by: glindsell <[email protected]>
Signed-off-by: glindsell <[email protected]>
/test integration |
Signed-off-by: glindsell <[email protected]>
/test integration |
Signed-off-by: glindsell <[email protected]>
/test integration |
/retest |
operator/go.mod
Outdated
@@ -6,21 +6,16 @@ require ( | |||
github.com/Azure/go-autorest/autorest v0.9.2 // indirect | |||
github.com/Azure/go-autorest/autorest/adal v0.7.0 // indirect | |||
github.com/go-logr/logr v0.1.0 | |||
github.com/gogo/protobuf v1.2.1 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we revert the changes to the go.mod
and go.sum
dependencies of the operator
? What triggered these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have merged with master and run go mod tidy
/test integration |
/retest |
Fri Dec 6 09:55:08 UTC 2019 impatient try |
Fri Dec 6 14:48:32 UTC 2019 impatient try |
Fri Dec 6 14:48:37 UTC 2019 impatient try |
/test integration |
Fri Dec 6 15:00:22 UTC 2019 impatient try |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ryandawsonuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#1138
(continued from #1181)
Updated Integration tests in line with Helm v3
Added to test README.md