Adding overrides to remove step that creates tag for Jenkins X pipeline #1161
Conversation
|
/cc @gsunner @adriangonz |
|
That's awesome! Is it skipping the |
|
@adriangonz that is correct, although it seems that right now there is still an issue as the pipeline expects the branch with the same name as the version exists, so we need to decide whether we are happy to overide the tag every time or whether we want to create a unique tag every time (although I can't think of a way to keep track. Here is all the detail: jenkins-x/jx#6230 |
axsaucedo
changed the title
axsaucedo
changed the title
|
It's now been addressed by continuously pushing the latest master into a branch v${VERSION}-SNAPSHOT branch. This branch is overriden every time there is a merged PR. There could be a race condition if two PR release pipelines are triggered at the exact same time. For the near to medium term we could have a look at creating a branch for all the releases to master, with either a counter, or with the github hash |
|
/approve |
|
@axsaucedo: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1124