Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing wrong types in Seldon Core user methods #1144 #1158

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

axsaucedo
Copy link
Contributor

Fixes #1144

@axsaucedo axsaucedo self-assigned this Nov 29, 2019
@axsaucedo
Copy link
Contributor Author

/approve
/lgtm

@seldondev
Copy link
Collaborator

@axsaucedo: you cannot LGTM your own PR.

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 1281306 into SeldonIO:master Nov 29, 2019
@axsaucedo axsaucedo removed their assignment May 13, 2021
@seldondev
Copy link
Collaborator

failed to trigger Pull Request pipeline

  • failed to create agent
  • failed to calculate in repo config
  • failed to load trigger config for repository SeldonIO/seldon-core for ref e64090e
  • failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha e64090e
  • failed to process repo SeldonIO/seldon-core refref e64090e
  • failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
  • open /var/tmp/gitrepo660600678/.lighthouse
  • no such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong types in Seldon Core user methods
2 participants