S2i integration #115
Merged
S2i integration #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maximophone
suggested changes
Mar 13, 2018
docs/wrappers/python.md
Outdated
|
|
||
| You can use these wrappers with any model that offers a python API. Some examples are: | ||
| * Scikit-learn | ||
| * Keras | ||
| * statsmodels |
There was a problem hiding this comment.
Any reason why statsmodels was removed?
docs/wrappers/python.md
Outdated
|
|
||
| After you have copied the required files in your model folder, you run the Seldon wrapper script to turn your model into a dockerised microservice. The wrapper script requires as arguments the path to your model directory, the model name, a version for the docker image, and the name of a docker repository. It will generate a "build" directory that contains the microservice, Dockerfile, etc. | ||
| * The file is call MyModel.py and it defines a class MyModel |
docs/wrappers/python.md
Outdated
| X : array-like | ||
| feature_names : array of feature names (optional) | ||
| """ | ||
| print("Predict called - will run idenity function") |
docs/wrappers/python.md
Outdated
|
|
||
| Let's explain each piece of this command in more details. | ||
| Define the core parametehttps://github.com/SeldonIO/seldon-core/tree/master/examples/transformersrs needed by our python builder image to wrap your model. An example is: |
There was a problem hiding this comment.
url in the middle of a word
docs/wrappers/python.md
Outdated
|
|
||
| ``` docker run seldonio/core-python-wrapper:0.7 ``` : run the core-python-wrapper container. | ||
| These values can also be provided or overrriden on the command line when building the image. |
Maximophone
suggested changes
Mar 13, 2018
wrappers/s2i/python/s2i/bin/usage
Outdated
| Sample MODEL invocation: | ||
| ------------------------ | ||
|
|
||
| s2i build https://github.com/seldonio/seldon-core.git --context-dir=wrappers/s2i/python/test/model-template-app seldonio/seldon-core-s2i-python seldon-core-template-model |
There was a problem hiding this comment.
seldonio/seldon-core-s2i-python3
wrappers/s2i/python/s2i/bin/usage
Outdated
| Sample ROUTER invocation: | ||
| ------------------------- | ||
|
|
||
| s2i build https://github.com/seldonio/seldon-core.git --context-dir=wrappers/s2i/python/test/router-template-app seldonio/seldon-core-s2i-python seldon-core-template-router |
wrappers/s2i/python/s2i/bin/usage
Outdated
| Sample TRANSFORMER invocation: | ||
| ------------------------------ | ||
|
|
||
| s2i build https://github.com/seldonio/seldon-core.git --context-dir=wrappers/s2i/python/test/transformer-template-app seldonio/seldon-core-s2i-python seldon-core-template-transformer |
docs/wrappers/python.md
Outdated
|
|
||
| For reference, here is the complete list of arguments that can be passed to the script. | ||
| An example invocation is: |
There was a problem hiding this comment.
Give example of using local code as well?
Maximophone
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #115