Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow meta tags to be provided in seldon_client #1096

Merged
merged 5 commits into from
Dec 9, 2019
Merged

Allow meta tags to be provided in seldon_client #1096

merged 5 commits into from
Dec 9, 2019

Conversation

ukclivecox
Copy link
Contributor

Fixes #821

@axsaucedo
Copy link
Contributor

/test lint

@axsaucedo
Copy link
Contributor

It seems the linter would reformat: would reformat /workspace/source/python/tests/test_seldon_client.py would reformat /workspace/source/python/seldon_core/seldon_clien
If you run make -C python/ run_linter it should add it (also activating the pre-commit-hook would do), other than that looks solid

@seldondev
Copy link
Collaborator

Mon Dec 9 15:57:12 UTC 2019
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1096/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1096 --build=6

@seldondev
Copy link
Collaborator

Mon Dec 9 15:57:24 UTC 2019
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1096/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1096 --build=7

@seldondev
Copy link
Collaborator

Mon Dec 9 17:24:00 UTC 2019
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1096/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1096 --build=8

@seldondev
Copy link
Collaborator

Mon Dec 9 17:24:13 UTC 2019
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1096/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1096 --build=9

@axsaucedo
Copy link
Contributor

/approve
/lgtm

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Mon Dec 9 22:26:33 UTC 2019
The logs for [lint] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1096/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1096 --build=11

@seldondev
Copy link
Collaborator

Mon Dec 9 22:26:46 UTC 2019
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1096/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1096 --build=10

@axsaucedo axsaucedo merged commit 5debc8a into SeldonIO:master Dec 9, 2019
@ukclivecox ukclivecox deleted the 821_meta_seldon_client branch February 14, 2020 11:37
@axsaucedo axsaucedo removed their assignment May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Python Seldon Client: support sending gRPC data with meta field
3 participants