Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gunicorn requirement from <19.10.0,>=19.9.0 to >=19.9.0,… #1089

Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

Updates the requirements on gunicorn to permit the latest version.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file Python labels Nov 11, 2019
@seldondev
Copy link
Collaborator

Hi @dependabot-preview[bot]. Thanks for your PR.

I'm waiting for a SeldonIO or seldonio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adriangonz
Copy link
Contributor

/test this
/cc @axsaucedo @cliveseldon

The only breaking changes according to http://docs.gunicorn.org/en/stable/news.html seem to be dropping support for Python 2.x, 3.2 ad 3.3. Therefore, we should be okay to merge?

@adriangonz
Copy link
Contributor

/ok-to-test

@adriangonz
Copy link
Contributor

/approve

The only manual change required was to remove the from gunicorn.six import iteritems import and instead use .items() directly. This is because gunicorn 20.x drops support for Python 2.x and therefore doesn't include six anymore.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adriangonz
Copy link
Contributor

@dependabot rebase

@dependabot-preview
Copy link
Contributor Author

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@axsaucedo
Copy link
Contributor

/test integration

dependabot-preview bot and others added 2 commits November 15, 2019 09:19
Updates the requirements on [gunicorn](https://github.com/benoitc/gunicorn) to permit the latest version.
- [Release notes](https://github.com/benoitc/gunicorn/releases)
- [Commits](benoitc/gunicorn@19.9.0...20.0.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@adriangonz adriangonz force-pushed the dependabot/pip/python/gunicorn-gte-19.9.0-and-lt-20.1.0 branch from cab65a4 to e1c314a Compare November 15, 2019 09:19
@adriangonz
Copy link
Contributor

/test integration

1 similar comment
@axsaucedo
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

@dependabot-preview[bot]: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration e1c314a link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor

It seems that all integration tests pass (only 1 failed due to KIND failing), so we can merge

@adriangonz
Copy link
Contributor

Nice @axsaucedo! Let's move on with this one then.

@adriangonz adriangonz changed the title Update gunicorn requirement from <19.10.0,>=19.9.0 to >=19.9.0,<20.1.0 in /python Update gunicorn requirement from <19.10.0,>=19.9.0 to >=19.9.0,… Nov 19, 2019
@adriangonz adriangonz merged commit 7a41483 into master Nov 19, 2019
@adriangonz adriangonz deleted the dependabot/pip/python/gunicorn-gte-19.9.0-and-lt-20.1.0 branch November 19, 2019 10:04
@axsaucedo
Copy link
Contributor

/approve
/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file ok-to-test Python size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants