Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests #1077

Merged
merged 5 commits into from
Nov 10, 2019
Merged

Fix integration tests #1077

merged 5 commits into from
Nov 10, 2019

Conversation

adriangonz
Copy link
Contributor

@adriangonz adriangonz commented Nov 8, 2019

Fixes #1076.

Changelog

  • Make tensorflow check more robust by testing the presence of what we need to import later on
  • Use local version of seldon-core on integration tests

@adriangonz
Copy link
Contributor Author

/test lint

1 similar comment
@adriangonz
Copy link
Contributor Author

/test lint

@adriangonz
Copy link
Contributor Author

/test this

@adriangonz
Copy link
Contributor Author

/ok-to-test

@adriangonz
Copy link
Contributor Author

/test this

@adriangonz
Copy link
Contributor Author

/test integration

1 similar comment
@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo
Copy link
Contributor

It seems the integration tests is getting stuck on:```Error from server (NotFound): deployments.extensions "mymodel-mymodel-e2eb561" not found
seldondeployment.machinelearning.seldon.io/mymodel created
Waiting for deployment "mymodel-mymodel-e2eb561" rollout to finish: 0 of 1 updated replicas are available...
deployment "mymodel-mymodel-e2eb561" successfully rolled out
seldondeployment.machinelearning.seldon.io/mymodel configured

Retesting again to see if it passes through this. 

/test all

@seldondev
Copy link
Collaborator

@adriangonz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 4dd0696 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor

Awesome stuff, this fixes it!
/approve

@axsaucedo
Copy link
Contributor

/lgtm

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit ab584d1 into SeldonIO:master Nov 10, 2019
@axsaucedo axsaucedo removed their assignment May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken integration tests
3 participants