Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executor #1016

Merged
merged 82 commits into from
Jan 27, 2020
Merged

Executor #1016

merged 82 commits into from
Jan 27, 2020

Conversation

ukclivecox
Copy link
Contributor

Initial rewrite of engine in GoLang.

Has more restricted functionality. See README in /executor.

Presently handles Seldon REST and gRPC but with restriction entire graph must only be made of REST or gRPC components - no mixing.

Designed so can be easily extended to handle other protocols, e.g. Tensorflow.

Unlikely to be ready until post 1.0 due to push of functionality outside this component e.g., metrics, meta data.

@ukclivecox
executor initial commit
11d88f6
@ukclivecox
initial e2e processing
c5c58d5
@ukclivecox
Merge branch 'master' into executor
f795b1b
@ukclivecox
Merge branch 'master' into executor
f24f6ee
@ukclivecox
update to refector and test transform - WIP
ac827cb
@ukclivecox
generalize executor payloads
188392a
@ukclivecox
update executor transform
598b13f
@ukclivecox
Merge branch 'master' into executor
7b3445f
@ukclivecox
add full predictor process
c61136b
@ukclivecox
rest client tests
2ab8b5b
@ukclivecox
correct type annotation for aggregate
b81f5de
@ukclivecox
go fmt
8710ff8
@ukclivecox
go vet
aaaf941
@ukclivecox
incorporate into operator
59b34b5
@ukclivecox
client updates
88f17c9
@ukclivecox
updated mean classifier
00e57f2
@ukclivecox
add proto folder
eb8219b
@ukclivecox
initial grpc commit
61077fb
@ukclivecox
grpc client initial commit
49a7b69
@ukclivecox
finish grpc server
4083d9f
@ukclivecox
rebase
da9ab75
@ukclivecox
Add rest server tests
e52cb74
@ukclivecox
Add grpc tests
ff04ed7
@ukclivecox
Add README
db3ba06
@ukclivecox
rebase
583b54d
@ukclivecox
Basic testing for model and abtests
f83875c
@ukclivecox
Update test for AB test
dc3b5c5
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cliveseldon

If they are not already assigned, you can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cliveseldon

If they are not already assigned, you can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Jan 24 17:49:23 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1016/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1016 --build=6

@seldondev
Copy link
Collaborator

Fri Jan 24 17:49:28 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1016/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1016 --build=7

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cliveseldon

If they are not already assigned, you can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Jan 24 17:59:22 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1016/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1016 --build=9

@seldondev
Copy link
Collaborator

Fri Jan 24 17:59:29 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1016/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1016 --build=8

@ryandawsonuk
Copy link
Contributor

/lgtm
/approve

Working on updating request logging to fit this new approach

@seldondev seldondev added the lgtm label Jan 27, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor

/lgtm

@axsaucedo
Copy link
Contributor

/hold

@axsaucedo
Copy link
Contributor

/hold cancel

@axsaucedo
Copy link
Contributor

/approve

@seldondev seldondev merged commit 72d40d6 into SeldonIO:master Jan 27, 2020
@ukclivecox ukclivecox mentioned this pull request Jan 31, 2020
Closed
@ukclivecox ukclivecox deleted the executor branch February 14, 2020 11:38
@thjwhite thjwhite mentioned this pull request May 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glindsell glindsell glindsell left review comments

@denominations-io denominations-io denominations-io left review comments

@axsaucedo axsaucedo axsaucedo left review comments

@phsiao phsiao phsiao left review comments

@ryandawsonuk ryandawsonuk ryandawsonuk approved these changes

Assignees
No one assigned
Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ukclivecox @seldondev @adriangonz @axsaucedo @ryandawsonuk @phsiao @denominations-io @glindsell