-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customized error raised in Python model needs be passed back to client #1010
Conversation
Hi @lennon310. Thanks for your PR. I'm waiting for a SeldonIO or seldonio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
engine/src/main/java/io/seldon/engine/service/InternalPredictionService.java
Show resolved
Hide resolved
engine/src/main/java/io/seldon/engine/service/InternalPredictionService.java
Show resolved
Hide resolved
/cc @adriangonz |
engine/src/main/java/io/seldon/engine/service/InternalPredictionService.java
Outdated
Show resolved
Hide resolved
/ok-to-test |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriangonz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
(1) Change
IOException
to explicitInvalidProtocolBufferException
.(2) Avoid re-throwing the
APIException
thrown whenhttpResponse.getStatusCode()
is non-2xx. However, any other exception is still caught and thrown asAPIExeption
.(3) Directly throw the exception with the payload as its message. The payload will be the
dict
defined in user defined exception in Python model.(4) The exception wrapper (
ExceptionControllerAdvice
class) should createSeldonMessage
instead ofStatus
(bug fix).