Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customized error raised in Python model needs be passed back to client #1010

Merged
merged 15 commits into from
Oct 30, 2019

Conversation

lennon310
Copy link
Contributor

@lennon310 lennon310 commented Oct 28, 2019

(1) Change IOException to explicit InvalidProtocolBufferException.

(2) Avoid re-throwing the APIException thrown when httpResponse.getStatusCode() is non-2xx. However, any other exception is still caught and thrown as APIExeption.

(3) Directly throw the exception with the payload as its message. The payload will be the dict defined in user defined exception in Python model.

(4) The exception wrapper (ExceptionControllerAdviceclass) should create SeldonMessage instead of Status (bug fix).

@seldondev
Copy link
Collaborator

Hi @lennon310. Thanks for your PR.

I'm waiting for a SeldonIO or seldonio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seldondev seldondev added size/XXL and removed size/M labels Oct 28, 2019
@seldondev seldondev added size/M and removed size/XXL labels Oct 28, 2019
@seldondev seldondev added size/L and removed size/M labels Oct 29, 2019
@axsaucedo
Copy link
Contributor

/cc @adriangonz

@seldondev seldondev requested a review from adriangonz October 29, 2019 09:16
@ukclivecox
Copy link
Contributor

/ok-to-test

@axsaucedo
Copy link
Contributor

/ok-to-test

@adriangonz
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants