Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from logback to log4j2 #1008

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Conversation

adriangonz
Copy link
Contributor

Fixes #1007.

Changelog

  • Add explicitly the spring-boot-starter package to handle excludes more cleanly
  • Remove org.springframework:spring-web, which is already being added by spring-boot-starter-web
  • Exclude spring-boot-starter-logging and add dependency on spring-boot-starter-log4j2

Notes

The only reason to add spring-boot-starter explicitly is that currently all the spring-boot-starter-* excludes are handled on spring-boot-starter-test, because it's the first one that appears. Since this one is also including spring-boot-starter, it makes sense to add it explicitly and specify the excludes there.

This is also the recommended way to do when the project combines multiple spring-boot-starter-* projects (e.g. here).

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: adriangonz

If they are not already assigned, you can assign the PR to them by writing /assign @adriangonz in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adriangonz
Copy link
Contributor Author

/cc @axsaucedo @cliveseldon

@adriangonz adriangonz self-assigned this Oct 28, 2019
@ukclivecox ukclivecox merged commit ca8282d into SeldonIO:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update logback
3 participants