Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug parsing boolean predictive unit params in Python wrappers #439

Closed
jklaise opened this issue Feb 11, 2019 · 0 comments · Fixed by #441
Closed

Bug parsing boolean predictive unit params in Python wrappers #439

jklaise opened this issue Feb 11, 2019 · 0 comments · Fixed by #441
Assignees
@jklaise
Labels
bug Python
Milestone
0.2.x

Comments

@jklaise
Copy link
Contributor

jklaise commented Feb 11, 2019

In the Python wrapper parsing the BOOL type predictive unit parameters doesn't work as bool("False") always evaluates to True in Python:

seldon-core/python/seldon_core/microservice.py

Lines 233 to 247 in 361db75

def parse_parameters(parameters):
type_dict = {
"INT": int,
"FLOAT": float,
"DOUBLE": float,
"STRING": str,
"BOOL": bool
}
parsed_parameters = {}
for param in parameters:
name = param.get("name")
value = param.get("value")
type_ = param.get("type")
parsed_parameters[name] = type_dict[type_](value)
return parsed_parameters

@jklaise jklaise added this to the 0.2.x milestone Feb 11, 2019
@jklaise jklaise self-assigned this Feb 11, 2019
@jklaise jklaise mentioned this issue Feb 11, 2019
Merged
agrski added a commit that referenced this issue Dec 2, 2022
@agrski
Add mTLS for data-flow engine (#439)
dabedfa 
* Add class for mTLS certificate/key config

* Add class for mTLS key-store config

* Move mTLS config to dedicated package

* Add type alias for keystore passwords

* Add skeleton of mTLS key-store config provider

* Add mTLS config to Kafka configurations for Streams & admin

* Add SSL to supported Kafka protocols

* Add CLI options for mTLS certificate/key file paths

* Use mTLS certs in key stores only when TLS is requested

* Pass mTLS certs config into Kafka config handler

* Add CA cert chain to trust store

* Fix typo in mTLS provider method name & corresponding var name

* Refactor trust store with reusable cert-loading method

* Ensure trust store output stream is closed

* Rename params for clarity

* Add private key to key store

The Java libraries except a certificate containing a corresponding public key to be added in this transaction.
The key is assumed to be RSA-encoded without a password (the no-DES option to OpenSSL).

* Use name for anonymous parameter

* Add TODO re full cert chain when adding private keys to a key store

* Use consistent formatting of 'use' resource blocks

* Add method generating random file locations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jklaise jklaise

Labels
bug Python
Projects
None yet
Milestone
0.2.x
Development

Successfully merging a pull request may close this issue.

Fix bug in parsing boolean params in Python wrapper jklaise/seldon-core
1 participant
@jklaise